Skip to content

chore: improve cucumber tests#7740

Merged
SWvheerden merged 1 commit intotari-project:developmentfrom
SWvheerden:sw_improve_ct
Apr 10, 2026
Merged

chore: improve cucumber tests#7740
SWvheerden merged 1 commit intotari-project:developmentfrom
SWvheerden:sw_improve_ct

Conversation

@SWvheerden
Copy link
Copy Markdown
Collaborator

Description

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors port management and cleanup logic in the integration test suite, specifically introducing a port pool for merge mining proxies and adding timeouts to the base node shutdown process. Feedback indicates that merge mining proxies lack a proper shutdown mechanism, which could lead to port conflicts when ports are re-allocated. Furthermore, the base node cleanup logic should be updated to provide a full timeout period for each individual port to avoid premature warnings.

@SWvheerden SWvheerden merged commit 93b7873 into tari-project:development Apr 10, 2026
14 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_improve_ct branch April 10, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant