chore: improve cucumber tests#7740
Merged
SWvheerden merged 1 commit intotari-project:developmentfrom Apr 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors port management and cleanup logic in the integration test suite, specifically introducing a port pool for merge mining proxies and adding timeouts to the base node shutdown process. Feedback indicates that merge mining proxies lack a proper shutdown mechanism, which could lead to port conflicts when ports are re-allocated. Furthermore, the base node cleanup logic should be updated to provide a full timeout period for each individual port to avoid premature warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description