feat: convert merge mining cucumber tests to RxT#7747
Open
0xskr33p wants to merge 2 commits intotari-project:developmentfrom
Open
feat: convert merge mining cucumber tests to RxT#77470xskr33p wants to merge 2 commits intotari-project:developmentfrom
0xskr33p wants to merge 2 commits intotari-project:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the standalone merge mining proxy process with a built-in XMRig proxy in the base node for integration tests. Key changes include the removal of the minotari_merge_mining_proxy dependency, the addition of xmrig_proxy_port to the base node configuration, and a significant refactoring of MergeMiningProxyProcess into a lightweight HTTP client. Corresponding updates were made to the port pool management, test world cleanup, and Gherkin feature files to reflect the simplified architecture. I have no feedback to provide.
c6274f5 to
d9ad2f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Convert merge mining integration tests from RandomX-Monero (RxM) to RandomX-Tari (RxT) by switching from the standalone
minotari_merge_mining_proxyto the base node's built-inxmrig_proxy.Key changes:
port_pool.rs: Addedxmrig_proxyport toBaseNodePorts; renamedmerge_mining_proxy_ports->xmrig_proxy_ports; removed standalone proxy port allocation methods.base_node_process.rs: Enabled built-inxmrig_proxyduring base node spawn (xmrig_proxy_enabled,xmrig_proxy_address,xmrig_proxy_wallet_payment_address).merge_mining_proxy.rs: Rewrote from external process launcher to lightweight HTTP client targeting the base node's built-in proxy; removed all Monero-specific config (monerod_url, wallet gRPC); removed unsupported methods (get_last_block_header,get_block_header_by_hash).merge_mining_steps.rs: Updated step definitions for new RxT API response format (76-byte hex blobs,submitblockinstead ofsubmit_block,countinstead ofheight).MergeMining.feature: Removed@brokentag; removed Monero origin submission scenario; adapted validation steps.BlockExplorerGRPC.feature: Removed wallet dependency that was only needed for the old standalone proxy.Cargo.toml: Removedminotari_merge_mining_proxydependency.world.rs: Updatedafterhook to returnxmrig_proxyports to pool on base node shutdown.Motivation and Context
#7737
How Has This Been Tested?
Results:
What process can a PR reviewer use to test or verify this change?
monerodconnections are attempted (no network calls to Monero stagenet nodes).Breaking Changes