Conversation
Summary of ChangesHello @thakel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on controlling the visibility of the Exolix swap feature within the mobile wallet application. It introduces a mechanism to hide the 'Buy XTM' button from the user interface by default, ensuring that the feature remains dormant until explicitly enabled for release. This approach allows for better management of feature rollouts and prevents premature exposure of unfinished functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| CODE_SIGN_IDENTITY = "Apple Development"; | ||
| CODE_SIGN_STYLE = Automatic; | ||
| CURRENT_PROJECT_VERSION = 7; | ||
| CURRENT_PROJECT_VERSION = 9; |
There was a problem hiding this comment.
Shouldn't it be automatic increment?
There was a problem hiding this comment.
I didn't update this so it was done automatically. The CI will probably override it too
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a feature flag to hide the Exolix swap feature. The implementation is straightforward, with a new boolean property isFeatureSupported in the Exolix service and a conditional check in the UI to show or hide the 'Buy XTM' button. My review includes a suggestion to make the feature flag more flexible by using a compilation directive instead of a hardcoded value. This will make it easier to enable the feature for testing in debug builds while keeping it disabled for release builds.
| var monitoredTransactions: Set<String> = [] | ||
| var latestTransactions = [String: ExolixTransactionResponse]() | ||
|
|
||
| let isFeatureSupported = false |
There was a problem hiding this comment.
For better flexibility during development and testing, consider using a compilation directive to control this feature flag. Hardcoding it to false requires a code change every time you want to enable it for a debug or test build.
A better approach would be to use the DEBUG flag, which is automatically defined by Xcode for debug builds. This would keep the feature enabled for developers and testers, but disabled in release builds. You can implement this cleanly using an immediately-executed closure.
let isFeatureSupported: Bool = {
#if DEBUG
return true
#else
return false
#endif
}()3 participants
Set feature flag to hidden until we're ready to release the feature