Conversation
Add scripts/test-templates.sh with flags: --no-bail: continue past failures --template <name>: test a specific template --no-clean: preserve generated dirs for inspection --output-dir <path>: custom output directory Template fixes: - ResourceBuilder::fungible() -> public_fungible() - strip = true for smaller WASM binaries - Fix Amount unsigned type changes - Fix stable_coin access rules and import paths - Fix test imports and API renames (call_args -> args) - Fix cargo-generate underscore/hyphen directory normalization Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29216592 | Triggered | Generic Password | 5be9983 | scripts/test-templates.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the development and testing workflow for Tari templates by introducing a comprehensive test automation script and updating all existing templates to be compatible with the latest Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily updates dependency versions across various Cargo.lock files, including tari_ootle_*, tari_template_lib_types, tari_engine_types, tari_template_abi, tari_template_lib, and other related crates. It also includes significant refactoring and API updates within the WASM templates, such as migrating types from tari_template_lib::models to tari_template_lib::types, utilizing ResourceBuilder::public_fungible(), and updating args! macro usage with explicit u64 type annotations. Additionally, a new test-templates.sh script has been introduced to automate testing of WASM templates and examples. Review feedback suggests improving the new bash script by using more idiomatic patterns for array membership checks.
- Use bash regex pattern for array membership instead of loops - Strip trailing slash from TMPDIR to prevent double slashes - Use Amount::new() in fungible test Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
… types - Use assert_reject_reason() helper instead of manual match/contains - Remove unused imports and prefix unused variables - Fix Amount type inference in swap (use Amount::from explicitly) - Fix Amount Sub<u64> ambiguity in meme_coin test Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…Cargo.lock files Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Summary
scripts/test-templates.shwith--no-bail,--template,--no-clean, and--output-dirflags plus a test summaryResourceBuilder::fungible()→public_fungible()across all templatesstrip = truein all template release profiles for smaller WASM binariesAmountunsigned type changes and import path updates fortari_template_lib0.22.xcall_args→args, import paths)Test plan
./scripts/test-templates.sh --template emptypasses./scripts/test-templates.sh --template counterpasses./scripts/test-templates.sh --no-bailruns all templates and reports summary🤖 Generated with Claude Code