Explicitely pass flag to decompress bzip2 archives in test#518
Merged
Leonidas-from-XIV merged 1 commit intotarides:mainfrom Mar 25, 2026
Merged
Explicitely pass flag to decompress bzip2 archives in test#518Leonidas-from-XIV merged 1 commit intotarides:mainfrom
Leonidas-from-XIV merged 1 commit intotarides:mainfrom
Conversation
`tar` on OpenBSD can decompress bzip2 but it does not do that automatically by default, unlike GNU tar or bsdtar. However all tar implementations support the `j` flag so might as well use it. This should fix tests on OpenBSD while keeping it working just fine on all other platforms too.
Leonidas-from-XIV
added
the
no changelog
shonfeder
approved these changes
Mar 25, 2026
Member
Author
|
The OpenBSD tests now all pass; merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at the CI results of #517 the (optional) OpenBSD tests are failing. But it looks that the only thing preventing them from passing is one single cram test.
taron OpenBSD can decompress bzip2 but it does not do that automatically by default, unlike GNU tar or bsdtar.However all tar implementations support the
jflag so might as well use it in the test - we know it's always going to be abzip2compressed file, so the autodetection is not necessary.This should fix tests on OpenBSD while keeping it working just fine on all other platforms too.