Editorial: deduplicate some work in atomics#2015
Merged
Conversation
jmdyck
reviewed
May 26, 2020
syg
approved these changes
Jun 8, 2020
Contributor
syg
left a comment
syg
left a comment
There was a problem hiding this comment.
Nice refactoring, centralizing the lea in a single place.
ljharb
approved these changes
Aug 10, 2020
bakkot
force-pushed
the
dedup-atomics-math
branch
from
1d1fec7 to
3a1b2ec
Compare
Member
Author
ljharb
pushed a commit
that referenced
this pull request
Sep 4, 2020
ljharb
force-pushed
the
dedup-atomics-math
branch
from
3a1b2ec to
25333f8
Compare
ljharb
pushed a commit
that referenced
this pull request
Sep 4, 2020
ljharb
force-pushed
the
dedup-atomics-math
branch
from
25333f8 to
ba298e8
Compare
ljharb
pushed a commit
that referenced
this pull request
Sep 4, 2020
ljharb
force-pushed
the
dedup-atomics-math
branch
from
ba298e8 to
87e833e
Compare
ljharb
force-pushed
the
dedup-atomics-math
branch
from
87e833e to
5a1a2df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #835. This includes two of the three commits in that PR; the third, 8e56f87, I am not inclined to take.
I'm neutral on the second commit, but included it for completeness.
(I opened a separate PR rather than just updating #835 because I wanted to drop 8e56f87 but didn't want to force-push it away.)
cc @anba @syg @lars-t-hansen