Skip to content

Editorial: avoid using Type macro for simple type tests#2874

Merged
ljharb merged 1 commit intomainfrom
GH-2870
Sep 1, 2022
Merged

Editorial: avoid using Type macro for simple type tests#2874
ljharb merged 1 commit intomainfrom
GH-2870

Conversation

@michaelficarra
Copy link
Copy Markdown
Member

This is a partial resolution for #2870, as suggested by @jmdyck.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Aug 30, 2022
@michaelficarra michaelficarra requested a review from a team August 30, 2022 03:55
@michaelficarra michaelficarra changed the title avoid using Type macro for simple type tests Editorial: avoid using Type macro for simple type tests Aug 30, 2022
Comment thread spec.html
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Aug 31, 2022
Copy link
Copy Markdown
Member

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review for completeness, but what's here LGTM.

I think it would be worth putting something in the "Object Type" section which specifically calls out that some members of the type are callable. The current "is logically a collection of properties" definition really obscures that. Not as part of this PR, though.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Sep 1, 2022
@ljharb ljharb merged commit 4154ec0 into main Sep 1, 2022
@ljharb ljharb deleted the GH-2870 branch September 1, 2022 19:01
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Sep 2, 2022
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Sep 2, 2022
anba added a commit to anba/ecma402 that referenced this pull request Aug 14, 2023
ben-allen pushed a commit to ben-allen/ecma402 that referenced this pull request May 24, 2024
ben-allen pushed a commit to ben-allen/ecma402 that referenced this pull request May 24, 2024
ben-allen pushed a commit to tc39/ecma402 that referenced this pull request May 24, 2024
ben-allen pushed a commit to tc39/ecma402 that referenced this pull request May 24, 2024
domenic pushed a commit to whatwg/html that referenced this pull request Oct 28, 2024
dizhang168 pushed a commit to dizhang168/html that referenced this pull request Oct 28, 2024
lozy219 pushed a commit to lozy219/html that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial change establishes editorial conventions ready to merge Editors believe this PR needs no further reviews, and is ready to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants