Skip to content

Add using and await using Declarations, SuppressedError, DisposableStack, and AsyncDisposableStack #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbuckton wants to merge 89 commits into
base: main
Choose a base branch
from
+1,302 −47
Open

Add using and await using Declarations, SuppressedError, DisposableStack, and AsyncDisposableStack #3000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
a05e15b
Spec text for proposal-explicit-resource-management
rbuckton Jan 23, 2023
bf546a0
Fix lint errors
rbuckton Jan 23, 2023
e32dfd6
Run formatter
rbuckton Jan 23, 2023
308e589
Fix signature for DisposeResources
rbuckton Jan 23, 2023
6a7d906
Fixes for some esmeta warnings
rbuckton Jan 23, 2023
2a7deda
Fixes for some esmeta warnings
rbuckton Jan 23, 2023
90cf454
Add missing ReturnIfAbrupt in DisposableStack.prototype.use
rbuckton Jan 23, 2023
62d03f2
More ecmarkup signature fixes
rbuckton Jan 23, 2023
92b922a
Change DisposeResources signature to return completion record
rbuckton Jan 24, 2023
fa19656
Order sections by property name
jmdyck Jan 24, 2023
b166dad
Syntax of types
jmdyck Jan 24, 2023
a96731e
id of AO clause doesn't need to include param names
jmdyck Jan 24, 2023
8700bce
Avoid the use of `Type()`
jmdyck Jan 24, 2023
3df3629
Use preamble conventions from PR #2592
jmdyck Jan 24, 2023
da52fb6
Interface names are put in `<i>` rather than `<em>`
jmdyck Jan 24, 2023
26876ea
A 'Slots' table should have a 'Type' column
jmdyck Jan 24, 2023
0330d8f
Add 'UsingDeclaration' to Annex A
jmdyck Jan 24, 2023
5f5c695
misc minor fixes
jmdyck Jan 24, 2023
ef84268
add description suggestion from @jmdyck
rbuckton Jan 25, 2023
8c22325
Add DisposeCapabilityRecord from tc39/proposal-explicit-resource-mana…
rbuckton Jan 25, 2023
d48fc3f
Wrap UpdateEmpty calls in calls to Completion
rbuckton Jan 25, 2023
13bc974
Run formatter
rbuckton Jan 25, 2023
e09a996
Run formatter again
rbuckton Jan 25, 2023
a302cd1
Fix formatting and capitalization
rbuckton Jan 26, 2023
46fca50
Clean up DisposeResources signature, replace UpdateEmpty with assertions
rbuckton Jan 26, 2023
39e2b20
Add 'either' in front of 'null or undefined'
rbuckton Jan 29, 2023
3daf70e
Use CreateBuiltinFunction
rbuckton Jan 29, 2023
224fb6a
Address additional editor feedback (from async PR)
rbuckton Jan 30, 2023
90c9732
Move BindingPattern restriction for 'using' to an early error
rbuckton Jan 30, 2023
d6a2342
Fix typo in using declaration early errors
rbuckton Jan 30, 2023
3c87ea3
Fix typos
rbuckton Jan 30, 2023
d4d10e9
run formatter
rbuckton Jan 30, 2023
6e90b41
Remove InstallErrorCause from SuppressedError, per 2023-jan consensus
rbuckton Jan 31, 2023
3b6e101
Spec text for proposal-async-explicit-resource-management
rbuckton Jan 27, 2023
e2a81a6
Run formatter
rbuckton Jan 27, 2023
c41c7a6
Add 'either' in front of 'null or undefined'
rbuckton Jan 29, 2023
81d9c33
Address editor feedback
rbuckton Jan 29, 2023
ffcaa25
Address additional editor feedback
rbuckton Jan 30, 2023
76c5252
Switch back to a production parameter, update ASI note
rbuckton Mar 22, 2023
a064c06
Remove 'await' restriction per March 2023 consensus. See tc39/proposa…
rbuckton Mar 27, 2023
9ae8dc8
Adopt consensus changes from tc39/proposal-explicit-resource-manageme…
rbuckton Mar 20, 2024
5e0ef35
Adopt consensus changes from tc39/proposal-explicit-resource-manageme…
rbuckton Mar 21, 2024
187f1e5
Adopt typo fix from tc39/proposal-explicit-resource-management#217
rbuckton Mar 21, 2024
eeeadf3
Fix typos and add temporary PR note
rbuckton Mar 22, 2024
cf79d80
Remove temporary PR note
rbuckton Mar 22, 2024
92162d7
Remaining consensus updates from proposal repo
rbuckton Mar 22, 2024
4c476c8
Add missing undefined check in GetDisposeMethod
rbuckton Mar 22, 2024
a397533
Fix DisposeCapability leak
rbuckton Mar 25, 2024
e6bafe4
fix formatting
rbuckton Mar 25, 2024
f6eb28f
Switch to empty list
rbuckton Apr 10, 2024
8eb8a3a
Update text of NOTE
rbuckton Apr 10, 2024
1aa6933
Add PromiseCapability wrapper around sync dispose in an `await using`
rbuckton Apr 10, 2024
c9ee3f4
Fix missing lookahead restriction
rbuckton Mar 22, 2024
b0aa2ce
Remove superfluous ClassBody restriction
rbuckton Mar 22, 2024
8aa6d7b
Add entries to esmeta-ignore
rbuckton May 24, 2024
6e4e9c8
Reduce unnecessary Awaits for nullish values in blocks containing `aw…
rbuckton Jun 15, 2024
537d29a
Add missing 'constructor' definitions
rbuckton Jan 8, 2025
8870333
Disallow using/await using in a switch case/default clause
rbuckton Mar 28, 2025
c7d6cb2
Fix formatting
rbuckton Mar 28, 2025
fcefbef
PR feedback
rbuckton Feb 27, 2026
b0a2658
minor fixes
rbuckton Feb 27, 2026
3cf68ee
Switch from @@ to % in a few more places
rbuckton Feb 27, 2026
1a0881c
Update esmeta-ignore.json
rbuckton Feb 27, 2026
3df474d
Update asyncDispose to be an async method
rbuckton Feb 27, 2026
e111ff7
avoid threading kind through all the InitializeBinding machinery
bakkot Mar 8, 2026
783db6e
rename _kind_ to _declarationKind_ in ForIn/OfBodyEvaluation
bakkot Mar 8, 2026
5d3f2d8
move _declarationKind_ into the branch where that makes sense
bakkot Mar 8, 2026
3784e9e
move it back
bakkot Mar 8, 2026
75abcd2
PR Feedback
rbuckton Mar 11, 2026
dba3a2b
Some missing changes pulled from rbuckton/ecma262#11
rbuckton Mar 11, 2026
be3c94e
Fix some remaining suggestions from rbuckton/ecma262#7
rbuckton Mar 11, 2026
41e38ce
Switch to <em> where appropriate
rbuckton Mar 11, 2026
2701bff
PR feedback
rbuckton Mar 12, 2026
f591ff1
The spec usually uses lower-case for ids.
jmdyck Mar 16, 2026
081c2d9
Drop 'variants' attribute
jmdyck Mar 16, 2026
851d4c7
Changes to Annex A to make it parallel to main-body grammar
jmdyck Mar 16, 2026
9a2e0c7
Add subclauses to "Constructor Properties of The Global Object"
jmdyck Mar 17, 2026
f0ad0b7
Need to define ForDeclarationBindingInitialization for ForDeclaration
jmdyck Mar 20, 2026
44c061c
Remove unreachable SDO rules
jmdyck Mar 20, 2026
4209174
Remove more unreachable SDO rules
jmdyck Mar 20, 2026
7aaa79f
Remove unnecessary steps in CreateDisposableResource
jmdyck Mar 20, 2026
6bd2d57
Add explicit return to algorithm
jmdyck Mar 20, 2026
b59523d
EvaluateClassStaticBlockBody: add an Assert
jmdyck Mar 20, 2026
0b11855
Don't overwrite completion parameter in DisposeResources
rbuckton Apr 12, 2026
8eb1ff8
Merge pull request #16 from jmdyck/3000_ed
rbuckton Apr 14, 2026
4657f92
Remove 'kind' description from InitializeBinding
rbuckton Apr 16, 2026
6f6afb3
CaseBlock can't have resources, so just assert
rbuckton Apr 16, 2026
ca3ff90
Restore missing NOTE and fix indentation
rbuckton Apr 16, 2026
73b2b1b
ContainsUsing and HasUnterminatedUsingDeclaration are identical
rbuckton Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions esmeta-ignore.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
[
"AsyncFromSyncIteratorContinuation",
"AsyncGeneratorYield",
"ClassStaticBlockBody[0,0].EvaluateClassStaticBlockBody",
"CompareTypedArrayElements",
"DoWait",
"EvaluateImportCall",
"FunctionBody[0,0].EvaluateFunctionBody",
"FunctionDeclarationInstantiation",
"GetViewByteLength",
"Record[SourceTextModuleRecord].ExecuteModule",
"TypedArrayLength"
]
Loading
Loading
⚡