Add comprehensive Decimal documentation and cookbook#198
Closed
jessealama wants to merge 9 commits intomainfrom
Closed
Add comprehensive Decimal documentation and cookbook#198jessealama wants to merge 9 commits intomainfrom
jessealama wants to merge 9 commits intomainfrom
Conversation
Collaborator
jessealama
commented
Oct 22, 2025
jessealama
commented
- Add documentation build system with Markdown support
- Create cookbook with practical Decimal usage examples
- Add why-decimal.md explaining the motivation for Decimal
- Add data-model.md explaining the technical design
- Add decimal.md with API reference
- Update package.json with documentation scripts
- Add .gitignore entries for generated docs
- Add documentation build system with Markdown support - Create cookbook with practical Decimal usage examples - Add why-decimal.md explaining the motivation for Decimal - Add data-model.md explaining the technical design - Add decimal.md with API reference - Update package.json with documentation scripts - Add .gitignore entries for generated docs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix invalid toPrecision(20) chaining syntax in why-decimal.md - Add missing parentheses to isNaN() and isFinite() method calls in cookbook.md - Fix grammar: "the number" → "the numbers" in why-decimal.md - Update exchange rate examples to use realistic rates (0.85 → 0.92545)
- Add proposal-decimal to devDependencies - Fix isNaN and isFinite method calls
The spec defines round() as:
round(numFractionalDigits, roundingMode)
where roundingMode is a string, not an options object.
Changed all examples from:
value.round(2, { roundingMode: "floor" })
to:
value.round(2, "floor")
This matches both the spec and the polyfill implementation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.