Correctly use hint in ForIn/OfBodyEvaluation#171
Merged
Conversation
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/171. |
rbuckton
changed the title
rbuckton
added
the
needs-consensus
Collaborator
Author
|
This was approved by consensus at the July, 2023 TC39 Plenary, but still needs reviews from the editors and reviewers before I can merge. @waldemarhorwat, @syg, @michaelficarra, @bakkot: can you please review? |
rbuckton
added
the
has-consensus
michaelficarra
approved these changes
Aug 22, 2023
Collaborator
Author
|
@waldemarhorwat, @syg: can you take a look at this? I have an approval from an editor but I'd like to get signoff from a reviewer before merging. |
Collaborator
Author
|
This has already been merged into rbuckton/ecma262#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an oversight in ForIn/OfBodyEvaluation to correctly use the hint variable initialized at the top of the algorithm when initializing the lhsRef binding via
InitializeReferencedBinding. This is necessary to correctly initialize a resource that usesSymbol.asyncDisposein the following statement:Fixes #172
cc: @tc39/ecma262-editors