Skip to content
This repository was archived by the owner on Jul 8, 2024. It is now read-only.

Normative: throw on negative set sizes #88

Merged
bakkot merged 2 commits into from
Jul 18, 2023
+1 −0
Merged

Normative: throw on negative set sizes #88

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a050672
Normative: coerce reported sizes to be non-negative
bakkot Jan 11, 2023
de9553f
switch to RangeError
bakkot Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ <h1>
1. NOTE: If _rawSize_ is *undefined*, then _numSize_ will be *NaN*.
1. If _numSize_ is *NaN*, throw a *TypeError* exception.
1. Let _intSize_ be ! ToIntegerOrInfinity(_numSize_).
1. If _intSize_ < 0, set _intSize_ to 0.
Copy link
Copy Markdown
Contributor

@zloirock zloirock Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to use ToLength?

Comment thread
ljharb marked this conversation as resolved.
Outdated
1. Let _has_ be ? Get(_obj_, *"has"*).
1. If IsCallable(_has_) is *false*, throw a *TypeError* exception.
1. Let _keys_ be ? Get(_obj_, *"keys"*).
Expand Down
⚡