Normative: Remove fallback paths in CalendarFields and CalendarMergeFields#2467
Merged
Normative: Remove fallback paths in CalendarFields and CalendarMergeFields#2467
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2467 +/- ##
==========================================
- Coverage 94.97% 94.94% -0.04%
==========================================
Files 20 20
Lines 10907 10891 -16
Branches 1998 1954 -44
==========================================
- Hits 10359 10340 -19
- Misses 487 504 +17
+ Partials 61 47 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ptomato
approved these changes
Jan 9, 2023
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Looks good, one suggestion for conciseness!
Needs an implementation in the reference polyfill, feel free to add it to this PR or open a separate one.
Collaborator
|
Marking as draft until presented at TC39. |
Member
|
What's the benefit to removing the fallback paths? |
ptomato
reviewed
Jan 13, 2023
Collaborator
See #2310. |
Aditi-1400
force-pushed
the
temporal-2310
branch
2 times, most recently
from
73bb98f to
b077a33
Compare
gibson042
approved these changes
Jan 23, 2023
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
Spec changes look good. Are we planning on updating the polyfill in this PR as well?
Aditi-1400
force-pushed
the
temporal-2310
branch
from
b077a33 to
b9e6313
Compare
Collaborator
Author
|
Test262 updates: tc39/test262#3785 |
ptomato
force-pushed
the
temporal-2310
branch
from
8eb1e97 to
2baf7fe
Compare
Collaborator
|
This got consensus at the 2023-01-31 TC39 plenary meeting, and the test262 tests are now in place. Thanks! |
ptomato
added a commit
that referenced
this pull request
Feb 16, 2023
This was a rebase error on my part when merging in #2467. My bad!
ptomato
added a commit
that referenced
this pull request
Feb 18, 2023
This was a rebase error on my part when merging in #2467. My bad!
ptomato
added a commit
that referenced
this pull request
Feb 27, 2023
This was a rebase error on my part when merging in #2467. My bad!
ptomato
added a commit
that referenced
this pull request
Mar 6, 2023
This was a rebase error on my part when merging in #2467. My bad!
justingrant
pushed a commit
to justingrant/proposal-temporal
that referenced
this pull request
Mar 11, 2023
This was a rebase error on my part when merging in tc39#2467. My bad!
ptomato
added a commit
that referenced
this pull request
Apr 7, 2023
This was a rebase error on my part when merging in #2467. My bad!
ptomato
added a commit
that referenced
this pull request
Apr 7, 2023
This was a rebase error on my part when merging in #2467. My bad!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2310
Also renames
DefaultMergeCalendarFieldstoISOMergeCalendarFieldssince it is no longer a default.