Conversation
…llible If we return before we do any calculations, then the _months_, _weeks_, and _days_ quantities come directly from a previous Duration Record, so they cannot cause CreateDateDurationRecord to fail. Reverse the sense of the check in the _largestUnit_ = *"day"* clause so it also becomes an early return and infallible.
Adding returns at the end of each largestUnit case makes it clearer that some duration units are definitely zero when we return.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2678 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 20 20
Lines 11986 11986
Branches 2227 2227
=======================================
Hits 11534 11534
Misses 389 389
Partials 63 63 ☔ View full report in Codecov by Sentry. |
Ms2ger
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are pulled out of #2612 to make the normative diff smaller.