Skip to content

Atomics relaxation#2633

Merged
rwaldron merged 18 commits intomasterfrom
atomics-relaxation
Jun 24, 2020
Merged

Atomics relaxation#2633
rwaldron merged 18 commits intomasterfrom
atomics-relaxation

Conversation

@rwaldron
Copy link
Copy Markdown
Contributor

@rwaldron rwaldron commented May 21, 2020

No description provided.

@rwaldron rwaldron requested a review from leobalter May 21, 2020 13:40
@anba
Copy link
Copy Markdown
Contributor

anba commented May 21, 2020

I don't understand testWithNonShareableBigIntTypedArrayConstructors and testWithNonShareableTypedArrayConstructors:

  • Both BigInt64Array and BigUint64Array can be used for all Atomics functions, except for Atomics.wait.
  • Only BigInt64Array can be used for Atomics.wait; BigUint64Array will throw for Atomics.wait.
  • Int(8|16|32)Array and Uint(8|16|32)Array can be used for all Atomics functions except for wait.
  • Only Int32Array can be wait, Int(8|16)Array and Uint(8|16|32)Array throw for wait.

@rwaldron
Copy link
Copy Markdown
Contributor Author

rwaldron commented May 27, 2020

@anba corrections pushed.

@rwaldron rwaldron force-pushed the atomics-relaxation branch 4 times, most recently from 59f8f8c to 35bc506 Compare June 3, 2020 18:04
leobalter
leobalter suggested changes Jun 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos. Otherwise the tests seem reasonable to me

Comment thread test/built-ins/Atomics/xor/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/add/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/and/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/compareExchange/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/exchange/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/load/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/notify/bigint/non-shared-bufferdata-count-evaluation-throws.js Outdated
Comment thread test/built-ins/Atomics/or/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/store/bigint/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/sub/bigint/non-shared-bufferdata.js Outdated
anba
anba suggested changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@anba anba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All calls to testWithAtomicsFriendlyTypedArrayConstructors ignore the TA parameter and instead are creating an Int32Array.

Comment thread test/built-ins/Atomics/or/non-shared-int-views-throws.js Outdated
Comment thread test/built-ins/Atomics/sub/non-shared-bufferdata.js Outdated
Comment thread test/built-ins/Atomics/xor/bigint/non-shared-bufferdata.js Outdated
rwaldron added 16 commits June 23, 2020 16:18
@rwaldron
Atomics.notify changed to always return 0 on non-shared
879b45e
@rwaldron
Atomics.load will operate on TA when TA.buffer is not a SharedArrayBu…
3dd40e8 
…ffer
@rwaldron
Atomics.store will operate on TA when TA.buffer is not a SharedArrayB…
0204bbe 
…uffer
@rwaldron
Atomics.add will operate on TA when TA.buffer is not a SharedArrayBuffer
ae3a3c0
@rwaldron
Atomics.and will operate on TA when TA.buffer is not a SharedArrayBuffer
bb385e4
@rwaldron
Atomics.compareExchange will operate on TA when TA.buffer is not a Sh…
14095fa 
…aredArrayBuffer
@rwaldron
Atomics.exchange will operate on TA when TA.buffer is not a SharedArr…
3d91ab0 
…ayBuffer
@rwaldron
Atomics: fix assertion messages
8e2a6c7
@rwaldron
Fix license lint & issues
bb3d3cd
@rwaldron
fixup! Atomics.and will operate on TA when TA.buffer is not a SharedA…
910a2f1 
…rrayBuffer
@rwaldron
Atomics.or will operate on TA when TA.buffer is not a SharedArrayBuffer
ed122f4
@rwaldron
Atomics.store will operate on TA when TA.buffer is not a SharedArrayB…
aa852f7 
…uffer
@rwaldron
Atomics.sub will operate on TA when TA.buffer is not a SharedArrayBuffer
a298d98
@rwaldron
Atomics.xor will operate on TA when TA.buffer is not a SharedArrayBuffer
bb1e1ff
@rwaldron
Atomics.* assertion messages and formatting
3888862
@rwaldron
Atomics: fix mispelled harness function name
2ca0754
@rwaldron rwaldron force-pushed the atomics-relaxation branch 2 times, most recently from c2927ca to cc772ef Compare June 23, 2020 20:20
@rwaldron rwaldron force-pushed the atomics-relaxation branch from cc772ef to f3272f2 Compare June 23, 2020 20:26
@rwaldron
Copy link
Copy Markdown
Contributor Author

rwaldron commented Jun 24, 2020

@leobalter thanks for thr ✅ , @anba thanks for the reviews

@rwaldron rwaldron merged commit 729fa02 into master Jun 24, 2020
@rwaldron rwaldron deleted the atomics-relaxation branch June 24, 2020 16:26
anba added a commit to anba/test262 that referenced this pull request Jun 25, 2020
@anba
Update Atomics.exchange to allow non-shared buffers
52f1c7d 
Follow-up for: tc39#2633
@anba anba mentioned this pull request Jun 25, 2020
Merged
rwaldron pushed a commit that referenced this pull request Jun 30, 2020
@anba @rwaldron
Update Atomics.exchange to allow non-shared buffers
836f609 
Follow-up for: #2633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@anba anba anba requested changes

@leobalter leobalter leobalter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwaldron @anba @leobalter
⚡