Conversation
Contributor
Author
|
I've left the changes in many individual commits in the hope that it makes review easier, but it probably makes more sense to land this as one commit. |
91 tasks
…lers through ToTemporalDate
…lers through ToTemporalDateTime
…lers through ToTemporalZonedDateTime
…lers through ToTemporalYearMonth
…lers through ToTemporalMonthDay
…lers through ToRelativeTemporalObject
…lers through AddDurationToOrSubtractDurationFromPlainYearMonth
ptomato
approved these changes
Jul 17, 2023
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I reviewed a representative sample of this, but it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the new PrepareTemporalFields behavior, that has some observable changes where many functions throw when encountering a calendar the fields() method of which returns duplicates, certain values that create duplicates internally,
__proto__orconstructor.See tc39/proposal-temporal#1315