Temporal: Audit of user code calls, part 4 (& last)#3939
Merged
Conversation
This was referenced Oct 4, 2023
ptomato
force-pushed
the
user-code-calls
branch
2 times, most recently
from
0f9649c to
eab0322
Compare
ptomato
force-pushed
the
user-code-calls
branch
from
eab0322 to
cfe268d
Compare
cjtenny
approved these changes
Nov 6, 2023
Contributor
cjtenny
left a comment
cjtenny
left a comment
There was a problem hiding this comment.
I promise I reviewed this thoroughly despite having no comments - all my comments in reviewing this came with thoroughly reviewing the normative changes accompanying it, and the tests do a great job covering that. Looks great to me :)
Two more test cases for a fast path that previously wasn't tested.
ptomato
force-pushed
the
user-code-calls
branch
from
cfe268d to
933395a
Compare
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next part following on from #3923. These tests should provide coverage for tc39/proposal-temporal#2519. Two commits, best reviewed separately.
Unlike the other parts of the user code calls audit, this part didn't add any new fast paths; all it does is ensure that a TimeZone or Calendar method is only looked up once during the course of any Temporal method call. Therefore, no new tests are added (except for a few methods which were missing an
order-of-operations.jsentirely). This PR only adjusts the expectations of existing tests.