Temporal: Tests for week-numbering algorithm#4009
Conversation
ptomato
left a comment
There was a problem hiding this comment.
Thanks! All these tests look good, with one comment about needing to move a few of them.
However I think we need to cover a few more things in order to make sure that engines implement every aspect of this normative change:
- In
test/built-ins/, validation that a custom calendar may return undefined fromyearOfWeekandweekOfYearand that a PlainDate/PlainDateTime/ZonedDateTime with this custom calendar will have theyearOfWeek/weekOfYearproperty with the value of undefined - In
test/intl402/, a sample case whereiso8601andgregoryweek numbers disagree according to CLDR
I'm happy to merge this after moving those two tests and add the additional coverage in a follow up, or also happy to re-review this with the additional tests added. Let me know what your preference is.
30a24e9 to
4ba2a79
Compare
I've updated the PR to add the tests you requested. |
ptomato
left a comment
There was a problem hiding this comment.
Thanks for the update, all looks good!
4ba2a79 to
c5f991d
Compare
Adds and updates tests for PR: tc39/proposal-temporal#2756