Conversation
ptomato
added
the
awaiting consensus
This was referenced May 15, 2024
gibson042
approved these changes
May 16, 2024
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
I'm not certain that we're not losing coverage with the removed files, but I did spot check a handful and it looks good.
See tc39/proposal-temporal#2825. This is a mass removal of tests that use this functionality, in a separate commit for ease of review. Further adjustments will be made in the following commit.
See tc39/proposal-temporal#2825. Various edits to existing tests so that they make more sense with the removal of relativeTo. New tests specifically testing that calendar units cannot be added or subtracted directly.
ptomato
force-pushed
the
temporal-2825-addition-relativeto
branch
from
2c404a7 to
c5d366c
Compare
ptomato
removed
the
awaiting consensus
Contributor
Author
|
This normative change achieved consensus at the TC39 plenary of 2024-06-12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corresponds to a yet-to-be-presented potential normative change, to simplify the Temporal proposal.
This PR is split into two commits, for ease of review. The first one is just a blanket removal of everything that tested the options parameter, and doesn't need to be reviewed very attentively. The second commit contains the actual tests.
See tc39/proposal-temporal#2825