Skip to content

Temporal: Tests for disallowed corner case in rounding durations#4152

Merged
ptomato merged 1 commit intotc39:mainfrom
ptomato:temporal-2902-rounding-increment-calendar
Sep 5, 2024
Merged

Temporal: Tests for disallowed corner case in rounding durations#4152
ptomato merged 1 commit intotc39:mainfrom
ptomato:temporal-2902-rounding-increment-calendar

Conversation

@ptomato
Copy link
Copy Markdown
Contributor

@ptomato ptomato commented Jul 15, 2024

This test covers a normative change to disallow an ambiguous corner case in the options bag for Temporal.Duration.prototype.round().

See tc39/proposal-temporal#2916

@ptomato ptomato requested a review from a team as a code owner July 15, 2024 23:53
@ptomato ptomato added needs review awaiting consensus This needs committee consensus before it can be eligible to be merged. labels Jul 15, 2024
@ptomato
Copy link
Copy Markdown
Contributor Author

ptomato commented Jul 30, 2024

Achieved consensus at TC39 plenary 2024-07-30.

@ptomato ptomato added has consensus This has committee consensus and removed awaiting consensus This needs committee consensus before it can be eligible to be merged. labels Jul 30, 2024
Copy link
Copy Markdown
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This test covers a normative change to disallow an ambiguous corner case
in the options bag for Temporal.Duration.prototype.round().

See tc39/proposal-temporal#2916
@ptomato ptomato force-pushed the temporal-2902-rounding-increment-calendar branch from 2e178cc to af9f702 Compare September 5, 2024 22:04
@ptomato
Copy link
Copy Markdown
Contributor Author

ptomato commented Sep 5, 2024

The spec PR is ready to be merged.

@ptomato ptomato merged commit c93ae0a into tc39:main Sep 5, 2024
@ptomato ptomato deleted the temporal-2902-rounding-increment-calendar branch September 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has consensus This has committee consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants