fix: template of Other runs in tkn-pac describe command#2018
Conversation
|
/test |
|
e2e test is not running for puneet at the moment which is expected since not yet in allowed list |
But should it be successful ? because one could merge this, without the test running (vs having something failing or in pending that "would" prevent that) |
|
i solved it differently see #2024 |
|
|
||
| {{ $.ColorScheme.Underline "Other Runs:" }} | ||
|
|
||
| {{ $.ColorScheme.Bold "STATUS:" }} {{ $.ColorScheme.Bold "Event" }} {{ $.ColorScheme.Bold "Branch" }} {{ $.ColorScheme.Bold "SHA" }} {{ $.ColorScheme.Bold "STARTED TIME" }} {{ $.ColorScheme.Bold "DURATION" }} {{ $.ColorScheme.Bold "PIPELINERUN" }} |
There was a problem hiding this comment.
There's no such reason, considering UX I removed it, I can add it back again if we don't want to change
|
can you add a screenshot before after please? that would help for review and release note. |
yep, added! |
Before this patch the output of other runs in the tkn pac describe command was not aligned properly Hence, with this patch it fixes and aligns the output Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
fix-tkn-pac-desc-template
branch
from
83ffa1f to
f0e81c0
Compare
|
/merge |
✅ PR Successfully Merged
Approvals Summary:
Thank you @PuneetPunamiya for your valuable contribution! 🎉 Automated by the PAC Boussole 🧭 |
4 participants
Before this patch the output of other runs in the tkn pac describe command was not aligned properly
Hence, with this patch it fixes and aligns the output
Screenshots
Before the fix
After the patch fix
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
(update the documentation accordingly)