fix: Triggering PipelineRun on label addition in Github PRs#2034
Merged
pipelines-as-code[bot] merged 1 commit intotektoncd:mainfrom Apr 9, 2025
Merged
Conversation
zakisk
force-pushed
the
SRVKP-7378-fix-pr-trigger-on-label-add-update
branch
from
c4feb31 to
1e70375
Compare
chmouel
reviewed
Apr 9, 2025
chmouel
approved these changes
Apr 9, 2025
Member
chmouel
left a comment
chmouel
left a comment
There was a problem hiding this comment.
LGTM, feel free to address the nit
zakisk
force-pushed
the
SRVKP-7378-fix-pr-trigger-on-label-add-update
branch
from
1e70375 to
3f52651
Compare
Member
Author
|
/test |
Member
Author
|
Actually the issue is causing when |
Member
|
@zakisk do you think we could test both? on-cel and with on-event and on-target-bvranch ? |
Member
Author
fixed an issue where PAC is triggering PipelineRuns on label addition on PRs when on-label annotation is not explicitly used and on-cel-expression is being used for matching event in PipelineRun definition. Now, before matching annotations it is checking for label_update event type and on-label annoation and if it doesn't present then ignoring the PipelineRun with a log message and still preserving on-cel-expression precendence over on-label. https://issues.redhat.com/browse/SRVKP-7378 https://issues.redhat.com/browse/SRVKP-7443 Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
zakisk
force-pushed
the
SRVKP-7378-fix-pr-trigger-on-label-add-update
branch
from
3f52651 to
0625a58
Compare
Member
|
/lgtm |
![pipelines-as-code[bot]](https://avatars.githubusercontent.com/in/112592?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats @zakisk your PR Has been approved 🎉
✅ Pull Request Approved
Approval Status:
- Required Approvals: 1
- Current Approvals: 1
👥 Reviewers Who Approved:
| Reviewer | Permission Level | Approval Status |
|---|---|---|
| @chmouel | admin |
✅ |
📝 Next Steps
- Ensure all required checks pass
- Comply with branch protection rules
- Request a maintainer to merge using the
/mergecommand (or merge it
directly if you have repository permission).
Automated by the PAC Boussole 🧭
Member
Author
|
/merge |
✅ PR Successfully Merged
Approvals Summary:
Thank you @zakisk for your valuable contribution! 🎉 Automated by the PAC Boussole 🧭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed an issue where PAC is triggering PipelineRuns on label addition on PRs when on-label annotation is not explicitly used and on-cel-expression is being used for matching event in PipelineRun definition.
Now, before matching annotations it is checking for label_update event type and on-label annoation and if it doesn't present then ignoring the PipelineRun with a log message and still preserving on-cel-expression precendence over on-label.
https://issues.redhat.com/browse/SRVKP-7378
https://issues.redhat.com/browse/SRVKP-7443
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the documentation accordingly)