Handles branch delete event on github#2044
Merged
chmouel merged 2 commits intotektoncd:mainfrom Apr 23, 2025
Merged
Conversation
PuneetPunamiya
force-pushed
the
fix-branch-delete-event-github
branch
from
2ae004a to
cfdfa82
Compare
Member
Author
|
Once this is merged, will raise a follow up PR for other git providers |
zakisk
reviewed
Apr 17, 2025
zakisk
reviewed
Apr 21, 2025
zakisk
reviewed
Apr 21, 2025
When a branch is deleted via repository UI, a push event is triggered and the payload will have a zero hash value Hence, this patch handles the deletion of branch deletion and returns early from ParsePayload function without further processing which in turn also avoids unnecessary log noise Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
fix-branch-delete-event-github
branch
from
15f7ad1 to
e2f5c8e
Compare
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a branch is deleted via repository UI, a push event is triggered and the payload will have a zero hash value
Hence, this patch handles the deletion of branch deletion and returns early from ParsePayload function without further processing which in turn also avoids unnecessary log noise
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)