Skip to content

chore: Ignore NotIn string in codespell#2055

Closed
zakisk wants to merge 1 commit intotektoncd:mainfrom
zakisk:add-notin-in-codespell
Closed

chore: Ignore NotIn string in codespell#2055
zakisk wants to merge 1 commit intotektoncd:mainfrom
zakisk:add-notin-in-codespell

Conversation

@zakisk
Copy link
Copy Markdown
Member

@zakisk zakisk commented Apr 16, 2025

ignore notin in codespell in order to make lint success

https://github.com/codespell-project/codespell?tab=readme-ov-file#ignoring-words

Changes

Submitter Checklist

  • 📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).

  • ♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.

  • ✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).

  • 📖 Document any user-facing features or changes in behavior.

  • 🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.

  • 🎁 If feasible, add an end-to-end test. See README for details.

  • 🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).

  • If adding a provider feature, fill in the following details:

    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

    (update the provider documentation accordingly)

ignore notin in codespell in order to make lint success

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
@chmouel
Copy link
Copy Markdown
Member

chmouel commented Apr 16, 2025

can't you just do inline error in your other pr with false positive ? https://github.com/codespell-project/codespell#inline-ignore

sometime notin is a proper spelling mistake

@zakisk
Copy link
Copy Markdown
Member Author

zakisk commented Apr 16, 2025

can't you just do inline error in your other pr with false positive ? https://github.com/codespell-project/codespell#inline-ignore

sometime notin is a proper spelling mistake

ah, I missed that doc, will do thanks!

@zakisk zakisk closed this Apr 16, 2025
@zakisk zakisk deleted the add-notin-in-codespell branch April 21, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants