chore: allow users to set the REG_PORT for make dev using a envvar#2057
Merged
chmouel merged 1 commit intotektoncd:mainfrom Apr 18, 2025
Merged
chore: allow users to set the REG_PORT for make dev using a envvar#2057chmouel merged 1 commit intotektoncd:mainfrom
make dev using a envvar#2057chmouel merged 1 commit intotektoncd:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the development documentation to allow users to specify a custom Docker registry port via the REG_PORT environment variable.
- Added a section detailing how to configure the registry port.
- Provided a code snippet showing how to set REG_PORT and run "make dev".
Files not reviewed (1)
- hack/dev/kind/install.sh: Language not supported
f4566ee to
a268e27
Compare
zakisk
reviewed
Apr 17, 2025
on Macs the ControlCenter listens on the port 5000 so wanted to set the 5001 port instead for REG_PORT this change ensures that the user it able to set the REG_PORT using an environment variable
051aab3 to
a5ea53e
Compare
Member
Author
Member
|
sounds good but we probably going to move everything to https://github.com/chmouel/startpaac soon :) |
Member
Author
|
@chmouel I created my own script for setting up PAC, wanted to test with github ANND have everything run on kind. Also, allowed me to replace the instance of pac running with ko apply -f config with KO_DOCKER_REPO=localhost:5001 |
Member
|
@waveywaves startpaac does that too (on local) ;) but no worries if you want to use your own... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On Apple Macs the ControlCenter listens on port 5000.
I wanted to use the 5001 port instead to avoid unauthorized errors while running
kobuilds.This change we ensures that the user it able to set the REG_PORT using an environment variable and then use
make devafter which consumes the REG_PORT env var to create the kind-registry exposed on the aforementioned port.Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)