Conversation
for testing
* Migrated E2E environment setup to the `startpaac` script target. * Removed redundant helper functions from `hack/gh-workflow-ci.sh`. * Simplified the E2E workflow definition by replacing multiple setup steps with a single `startpaac` call. * Configured workflow parameters to use `vars` instead of `secrets` where appropriate. * Updated E2E test URLs to use `https`. * Updated the default internal Gitea URL in tests to reflect the environment setup. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the environment configuration for end-to-end tests to transition from Gitea to Forgejo, aligning test URLs and commands accordingly.
- Updated internal URL configurations in tests to point to Forgejo.
- Modified workflow triggers and environment variables to support new setup and script changes.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/pkg/gitea/test.go | Updated internal URL for Forgejo deployment |
| .github/workflows/e2e.yaml | Adjusted event trigger configuration and environment variable values |
Files not reviewed (1)
- hack/gh-workflow-ci.sh: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/e2e.yaml:127
- [nitpick] Ensure that the naming of the 'startpaac' script clearly reflects its functionality, and update documentation accordingly so users are aware of the new command.
./hack/gh-workflow-ci.sh startpaac
.github/workflows/e2e.yaml:13
- Switching from 'pull_request_target' to 'pull_request' may affect access to repository secrets for PRs from forks. Verify that this change doesn't inadvertently restrict secrets for valid contributors.
pull_request:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP but seems to work on my fork now.
this would make things a bit easier and move us to forgejo
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)