deps: update dependencies by chmouel · Pull Request #2249 · tektoncd/pipelines-as-code

chmouel · 2025-09-17T09:03:30Z

📝 Description of the Change

This pull request updates tooling dependencies and refines style and spelling configurations for documentation and CI pipelines. The most significant changes are grouped below by theme.

CI and Tooling Updates:

Upgraded the golang image version from 1.23 to 1.24 across all Tekton pipeline YAML files (.tekton/doc.yaml, .tekton/generate-coverage-release.yaml, .tekton/go.yaml, .tekton/linter.yaml) to ensure compatibility with the latest Go features and security patches. [1] [2] [3] [4] [5] [6] [7]
Updated the pre-commit hook configuration to use pre-commit-hooks version v6.0.0 for improved linting and file checks. (.pre-commit-config.yaml)

Vale Style and Spelling Improvements:

Expanded the list of exceptions and filters in Vale style files to better handle technical terms, abbreviations, and project-specific vocabulary, including many new AI/ML-related terms and acronyms in .vale/styles/RedHat/Definitions.yml, .vale/styles/RedHat/PascalCamelCase.yml, and .vale/styles/RedHat/Spelling.yml. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]
Added and reorganized exception patterns in .vale/styles/RedHat/Slash.yml to better support technical terms and repository names containing slashes, improving the accuracy of style checks for AI, ML, and open source projects. [1] [2]

Case Sensitivity and Term Handling:

Improved handling of case-sensitive terms, such as moving 'dotNet': .NET and adding a comprehensive regex for NVIDIA, ensuring correct capitalization and replacement in .vale/styles/RedHat/CaseSensitiveTerms.yml. [1] [2]

Spelling Filter Adjustments:

Relocated several common abbreviations and technical terms from one part of the spelling filter to another within .vale/styles/RedHat/Spelling.yml for better organization and coverage. Also added new terms related to AI/ML and data science. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

These changes collectively improve the maintainability and accuracy of CI pipelines and documentation style enforcement, especially for modern technical and AI/ML-related terminology.

🔗 Linked GitHub Issue

Fixes #

👨🏻‍ Linked Jira

🚀 Type of Change

🧪 Testing Strategy

✅ Submitter Checklist

Detailed changes - Bump Go language version: 1.23.8 -> 1.24.0 - Update toolchain to go1.24.2 - Refresh and upgrade a number of direct dependencies, notable bumps: - code.gitea.io/gitea v1.23.7 -> v1.24.6 - code.gitea.io/sdk/gitea v0.21.0 -> v0.22.0 - github.com/bradleyfalzon/ghinstallation/v2 v2.15.0 -> v2.16.0 - github.com/chzyer/readline v0.x -> v1.5.1 - github.com/cloudevents/sdk-go/v2 v2.16.0 -> v2.16.1 - github.com/google/cel-go v0.25.0 -> v0.26.1 - github.com/google/go-github/v71 v71.0.0 -> github.com/google/go-github/v74 v74.0.0 (plus updated scrape pseudo-version) - github.com/jenkins-x/go-scm v1.15.10 -> v1.15.16 - github.com/ktrysmt/go-bitbucket v0.9.85 -> v0.9.87 - github.com/spf13/cobra v1.9.1 -> v1.10.1 - github.com/stretchr/testify v1.10.0 -> v1.11.1 - github.com/tektoncd/pipeline v1.0.0 -> v1.4.0 - gitlab.com/gitlab-org/api/client-go v0.128.0 -> v0.145.0 - golang.org/x/* (exp, oauth2, sync, text) bumped to newer pseudo-versions/semver - k8s.io modules: api, apimachinery, client-go bumped (see below) - knative.dev/eventing and knative.dev/pkg bumped - sigs.k8s.io/yaml v1.4.0 -> v1.6.0 - Indirect dependency updates and additions: - cel.dev/expr v0.23.1 -> v0.24.0 (indirect) - cert-manager, cloudevents/sql, coreos/go-oidc, fxamacker/cbor, and others bumped - added several go-openapi/swag subpackages v0.24.0 (indirect) to resolve transitive needs - google.golang.org modules updated (api, genproto, grpc, protobuf) - prom and related packages bumped (prometheus/common, procfs, client_golang) - many golang.org/x/* indirect bumps (crypto, net, sys, term, time) - k8s.io/kube-openapi pinned and other indirect k8s-related bumps - Replace block changes: - pinned github.com/go-jose/go-jose/v4 => v4.0.5 kept - updated/realigned k8s replacements: - k8s.io/api & k8s.io/apimachinery replaced to v0.32.8 (previously pinned to 0.32.4) - k8s.io/client-go replace added to v0.32.4 - k8s.io/kube-openapi kept as existing indirect pseudo-version - knative.dev/eventing & knative.dev/pkg replaced to specific older versions (to maintain compatibility with other modules) - restored github.com/google/gnostic-models => v0.6.9 in the replace block - sigs.k8s.io/gateway-api replace updated to v1.0.0 (kept/pinned) - Note: some requires use newer k8s versions while replaces pin certain modules to specific versions to avoid version skew and transient incompatibilities. Why - Move to Go 1.24 to pick up language and toolchain improvements and to stay current with tooling/CI. - Upgrade dependencies to pull fixes, performance improvements, and API updates required by transitive libraries. - Adjust replace directives to resolve module graph conflicts and keep k8s/knative-related modules consistent across transitive dependencies. Footer - No explicit BREAKING CHANGES declared here, but the k8s/knative/major-library bumps may require code changes; treat as "possible breaking changes" and validate accordingly. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

* Updated Go image to version 1.24. * Applied version upgrade across Tekton pipeline tasks for `doc`, `generate-coverage-release`, `go`, and `linter`. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

* Updated pre-commit hooks to version 6.0.0. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

* Added `NVIDIA` to case-sensitive terms. * Normalized `dotNet` casing. * Included various AI/ML acronyms and technical terms in definition exceptions. * Added numerous AI/ML model and project names to PascalCase/CamelCase exceptions. * Removed `NVidia` from PascalCase/CamelCase and spelling exceptions. * Included URLs and `CI/CD` in slash exceptions. * Added many AI/ML-related repository patterns to slash exceptions. * Added various AI/ML specific spelling exceptions such as `finetune`, `multimodal`, `quantizable`, `smoothquant`, `sparsification`, and `tokenizers`. * Refined the `env` rule to suggest `environment` more accurately. * Refined the `builtin` rule. * Improved the `k8s` suggestion rule to prevent false positives. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Copilot

Pull Request Overview

This pull request updates tooling dependencies and refines style and spelling configurations for documentation and CI pipelines. The updates ensure compatibility with the latest Go features and improve documentation quality checks, particularly for AI/ML-related terminology.

Updates Go dependencies from v71 to v74 for the go-github library across numerous files
Upgrades Go runtime version from 1.23 to 1.24 in CI pipeline configurations
Expands Vale style configurations with AI/ML terminology and technical terms

Reviewed Changes

Copilot reviewed 69 out of 1032 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
go.mod	Updates Go version and numerous dependencies including go-github to v74
Multiple test and pkg files	Updates go-github import from v71 to v74
.tekton/*.yaml	Updates Go image version from 1.23 to 1.24
.pre-commit-config.yaml	Updates pre-commit-hooks from v5.0.0 to v6.0.0
.vale/styles/RedHat/*.yml	Adds AI/ML terminology and improves spell checking configurations
pkg/provider/github/parse_payload.go	Imports both v72 and v74 versions of go-github

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

gemini-code-assist

Summary of Changes

Hello @chmouel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's continuous integration (CI) pipelines and documentation consistency. It updates core tooling dependencies and refines style and spelling configurations to better align with modern technical terminology, particularly in the AI/ML domain. These changes collectively improve the maintainability and accuracy of automated checks and documentation enforcement.

Highlights

Go Version Update: Upgraded the golang image version from 1.23 to 1.24 across all Tekton pipeline YAML files to ensure compatibility with the latest Go features and security patches.
Pre-commit Hooks Update: Updated the pre-commit hook configuration to use pre-commit-hooks version v6.0.0 for improved linting and file checks.
Vale Style and Spelling Enhancements: Expanded the list of exceptions and filters in Vale style files to better handle technical terms, abbreviations, and project-specific vocabulary, including many new AI/ML-related terms and acronyms.
Slash Rule Adjustments: Added and reorganized exception patterns in .vale/styles/RedHat/Slash.yml to better support technical terms and repository names containing slashes, improving the accuracy of style checks for AI, ML, and open source projects.
Case Sensitivity Improvements: Improved handling of case-sensitive terms, such as moving 'dotNet': .NET and adding a comprehensive regex for NVIDIA, ensuring correct capitalization and replacement in .vale/styles/RedHat/CaseSensitiveTerms.yml.
Spelling Filter Refinements: Relocated several common abbreviations and technical terms from one part of the spelling filter to another within .vale/styles/RedHat/Spelling.yml for better organization and coverage, and added new terms related to AI/ML and data science.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates various dependencies, including Go, Tekton pipelines, and pre-commit hooks. It also significantly expands the Vale style and spelling configurations to better handle technical and AI/ML-related terminology. The changes are mostly straightforward dependency bumps and configuration updates. However, there are some concerns regarding the Go module dependencies, particularly with k8s.io and knative.dev versions, which appear inconsistent and could lead to issues. There is also a minor duplication in the Vale spelling configuration.

chmouel · 2025-09-17T09:16:21Z

we need to pin some of the knative/k8s go dependencies since knative removed knative.dev/pkg/metrics and the change is huge for us

tektoncd/pipeline#8969

chmouel · 2025-09-17T09:17:21Z

The gemini review don't make sense here

chmouel added 4 commits September 17, 2025 11:00

chore: Upgrade Go image to 1.24

64f260f

* Updated Go image to version 1.24. * Applied version upgrade across Tekton pipeline tasks for `doc`, `generate-coverage-release`, `go`, and `linter`. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

chore: Update pre-commit hooks to v6.0.0

ef502fb

* Updated pre-commit hooks to version 6.0.0. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Copilot AI review requested due to automatic review settings September 17, 2025 09:03

chmouel changed the title ~~chore(deps): update Go dependencies~~ chore: update dependencies Sep 17, 2025

Copilot AI reviewed Sep 17, 2025

View reviewed changes

Comment thread pkg/provider/github/parse_payload.go

Comment thread pkg/provider/github/parse_payload.go

Comment thread .vale/styles/RedHat/TermsErrors.yml

gemini-code-assist bot reviewed Sep 17, 2025

View reviewed changes

Comment thread go.mod

zakisk approved these changes Sep 17, 2025

View reviewed changes

zakisk changed the title ~~chore: update dependencies~~ deps: update dependencies Sep 17, 2025

chmouel merged commit 79c8e77 into tektoncd:main Sep 17, 2025
5 checks passed

chmouel deleted the update-deps branch September 17, 2025 10:48

github-actions bot mentioned this pull request Sep 27, 2025

[openshift-pipelines/pipelines-as-code] v0.38.0 vdemeester/chick-group#159

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update dependencies#2249

deps: update dependencies#2249
chmouel merged 4 commits intotektoncd:mainfrom
chmouel:update-deps

chmouel commented Sep 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

chmouel commented Sep 17, 2025 •

edited

Loading

Uh oh!

chmouel commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chmouel commented Sep 17, 2025

📝 Description of the Change

🔗 Linked GitHub Issue

👨🏻‍ Linked Jira

🚀 Type of Change

🧪 Testing Strategy

✅ Submitter Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chmouel commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chmouel commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chmouel commented Sep 17, 2025 •

edited

Loading