Skip to content

chore: Update Go and third-party dependencies#2656

Merged
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:update-go-jose-security-fix
Apr 8, 2026
Merged

chore: Update Go and third-party dependencies#2656
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:update-go-jose-security-fix

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Apr 8, 2026

📝 Description of the Change

Updated Go to version 1.25.7 and refreshed several Go modules, including github.com/google/cel-go, github.com/tektoncd/pipeline, go.opentelemetry.io/otel, and knative.dev/eventing to incorporate recent improvements and security patches.

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Updated Go to version 1.25.7 and refreshed several Go modules, including
`github.com/google/cel-go`, `github.com/tektoncd/pipeline`,
`go.opentelemetry.io/otel`, and `knative.dev/eventing` to incorporate
recent improvements and security patches.

This clear security issue on go jose for example

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel requested a review from zakisk April 8, 2026 09:45
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.80%. Comparing base (a387d41) to head (cf177e7).
⚠️ Report is 2 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2656   +/-   ##
=======================================
  Coverage   58.80%   58.80%           
=======================================
  Files         206      206           
  Lines       20304    20304           
=======================================
  Hits        11940    11940           
  Misses       7591     7591           
  Partials      773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version to 1.25.7 and increments several dependency versions, including Tekton pipelines, OpenTelemetry, and various Kubernetes-related libraries. Feedback points out a discrepancy between the pull request description and the actual changes, specifically noting that intended security updates for the go-jose dependency are missing from the go.mod file.

Comment thread go.mod
@chmouel chmouel merged commit 69c1197 into tektoncd:main Apr 8, 2026
22 of 23 checks passed
@chmouel chmouel deleted the update-go-jose-security-fix branch April 8, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants