Fix deleteting previosly closed streams.#2351
Merged
Merged
Conversation
Previously we delete previously closed streams in case when count of closed streams is greater then TFW_MAX_CLOSED_STREAMS. But there is a case when count of streams is equal to max concurrent streams when we should close all closed streams to be able to create new streams.
We should immediately return in case of error not use '|=' to collect result.
const-t
approved these changes
Mar 10, 2025
| if (closed_streams->num <= TFW_MAX_CLOSED_STREAMS) { | ||
| if (closed_streams->num <= TFW_MAX_CLOSED_STREAMS | ||
| && (ctx->streams_num < max_streams | ||
| || !closed_streams->num)) { |
Contributor
There was a problem hiding this comment.
I'm ok with current solution, however I would like to ask, maybe we need account ctx->streams_num excluding closed_streams->num?
Contributor
Author
There was a problem hiding this comment.
No! Streams moved to closed_streams queue after sending all data to the client or when RST stream is received. If we don't take them into account we never delete this streams from memory
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we delete previously closed streams in
case when count of closed streams is greater then
TFW_MAX_CLOSED_STREAMS. But there is a case when
count of streams is equal to max concurrent streams when we should close all closed streams to be able to create new streams.