Fix locale-sensitive URL formatting and minor issues#2
Open
nyghtowl wants to merge 1 commit into
Open
Conversation
…urability docs - Add Locale.ROOT to String.format in WeatherTools/ToolActivitiesImpl across all 4 demos — without it, European locales (e.g. Spanish on machines at Spring I/O Barcelona) produce commas as decimal separators in the Open-Meteo URL, breaking every weather lookup - Fix potential NPE in demo4 Starter when workflow failure has no cause - Remove unused MCP_CONFIG variable from setup-f1-server.sh - Add standalone setup/troubleshooting section to root README (notes that Instruqt handles setup at the live workshop; covers independent use) - Add "Try the durability" section to demo1 README with step-by-step crash/restart instructions; demo2 links to it Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locale.ROOTtoString.formatin weather URL construction — without it, European locales (includingSpanish, the default on many machines at Spring I/O Barcelona) produce commas as decimal separators, breaking every weather API call
Startererror path whene.getCause()is nullMCP_CONFIGvariable fromsetup-f1-server.shTest plan