Provide a toggle to disable the volume_tags#195
Closed
dekimsey wants to merge 1 commit into
Closed
Conversation
Since lifecycle is a dynamic property, we have to create a separate resource that has this feature disabled. It's not the most graceful workaround, but it works well enough. The default will keep the current behavior unchanged. Any users who desire to enable this on existing resources would need to perform a `state mv` to avoid replacing resources.
dekimsey
force-pushed
the
toggle-volume-tags
branch
from
64289a9 to
a0830fe
Compare
Author
|
Day after I submit this, the aws provider adds a fix that may address this behavior. Perfect. Scheduled for aws provider v3.24.0 hashicorp/terraform-provider-aws#15474 Closing. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note, while this works it's a pretty clunky solution. I'm putting this out there as an option.
Currently using this module while also adding a ebs_volume_attachment causes apply churn as the aws_instance's volume_tags conflict with additional tags added outside of the module.
This change introduces a new internal resource that has the
lifecycle ignore_changesproperty set to ignorevolume_tags. While clunky, this was the only way to address the volume tag churn.Perhaps in the future it can be removed if the upstream is able to define a sane way of managing these conflicting entries.
Motivation and Context
Since lifecycle is a dynamic property, we have to create a separate
resource that has this feature disabled. It's not the most graceful
workaround, but it works well enough.
Breaking Changes
The default will keep the current behavior unchanged. Any users who
desire to enable this on existing resources would need to perform a
state mvto avoid replacing resources.How Has This Been Tested?
I applied the changes on an existing host to verify the move is without issue. I applied by also tainting and re-running.
Related