Add support for function callbacks as the target of EvaluateExpr#246
Merged
Add support for function callbacks as the target of EvaluateExpr#246
Conversation
This was referenced Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #196 #236
I initially deprecated the
EnsureNoErrorfunction and thought that the caller should useerrors.Is()to determine the error. However, during several works, I came to the conclusion that this would likely cause new confusion.In this PR, I will make changes to support function callbacks as the target for
EvaluateExpr. The evaluated value will be passed as an argument to the callback and executed. In cases where the value cannot be represented as an argument, such as unknown values, NULL, or sensitive values, the callback execution will be aborted instead of returning an error.In other words, all of the following implementations are equivalent:
If you are using the
EnsureNoErrorfunction, you need to switch to the function callback approach to keep the current behavior. If you need to change the behavior based on the type of error, useerrors.Is()to check the type of error instead of usingEnsureNoError.