Summary
The PR #1174 (ROSAENG-6793) introduced reviseZeroEgressNoProxy, a helper that strips API-appended zero-egress default domains from proxy.no_proxy in state before persisting. This helper is invoked at the end of Create, Read, and Update.
Subsystem tests were added covering Create and Read/refresh paths, but no test exercises the Update (PATCH) path yet.
Task
Add an It block in subsystem/hcp/cluster_resource_test.go (within the Test Proxy / zero-egress context) that:
- Creates a zero-egress cluster (reuse POST/GET handlers similar to the existing create test).
- Simulates an update by changing
proxy.no_proxy in Terraform.Source and calling Terraform.Apply().
- Mocks the PATCH response with
aws.zero_egress.no_proxy_default_domains and API-appended default domains in proxy.no_proxy.
- Asserts
Terraform.Resource("rhcs_cluster_rosa_hcp", "my_cluster").attributes.proxy.no_proxy equals only the user-specified value (e.g., "new.custom.domain").
References
Summary
The PR #1174 (ROSAENG-6793) introduced
reviseZeroEgressNoProxy, a helper that strips API-appended zero-egress default domains fromproxy.no_proxyin state before persisting. This helper is invoked at the end of Create, Read, and Update.Subsystem tests were added covering Create and Read/refresh paths, but no test exercises the Update (PATCH) path yet.
Task
Add an
Itblock insubsystem/hcp/cluster_resource_test.go(within theTest Proxy/ zero-egress context) that:proxy.no_proxyinTerraform.Sourceand callingTerraform.Apply().aws.zero_egress.no_proxy_default_domainsand API-appended default domains inproxy.no_proxy.Terraform.Resource("rhcs_cluster_rosa_hcp", "my_cluster").attributes.proxy.no_proxyequals only the user-specified value (e.g.,"new.custom.domain").References