Skip to content

Add DCO sign-off requirement to CONTRIBUTING.md#1193

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
amandahla-patch-2
Jun 12, 2026
Merged

Add DCO sign-off requirement to CONTRIBUTING.md#1193
openshift-merge-bot[bot] merged 1 commit into
mainfrom
amandahla-patch-2

Conversation

@amandahla

@amandahla amandahla commented Jun 11, 2026

Copy link
Copy Markdown
Member

Added a note about DCO sign-off requirement for commits.

PR Summary

Detailed Description of the Issue

Related Issues and PRs

  • Jira: OCM-XXXXX
  • Fixes: #
  • Related PR(s):
  • Related design/docs:

Type of Change

  • feat - adds a new user-facing capability.
  • fix - resolves an incorrect behavior or bug.
  • docs - updates documentation only.
  • style - formatting or naming changes with no logic impact.
  • refactor - code restructuring with no behavior change.
  • test - adds or updates tests only.
  • chore - maintenance work (tooling, housekeeping, non-product code).
  • build - changes build system, packaging, or dependencies for build output.
  • ci - changes CI pipelines, jobs, or automation workflows.
  • perf - improves performance without changing intended behavior.

Previous Behavior

Behavior After This Change

How to Test (Step-by-Step)

Preconditions

Test Steps

Expected Results

Proof of the Fix

  • Screenshots:
  • Videos:
  • Logs/CLI output:
  • Other artifacts:

Breaking Changes

  • No breaking changes
  • Yes, this PR introduces a breaking change (describe impact and migration plan below)

Breaking Change Details / Migration Plan

Developer Verification Checklist

  • Commit subject/title follows [JIRA-TICKET] | [TYPE][(scope)][!]: <MESSAGE>.
  • PR description clearly explains both what changed and why.
  • Relevant Jira/GitHub issues and related PRs are linked.
  • make install-hooks has been run in this clone.
  • Tests were added/updated where appropriate.
  • I manually tested the change.
  • make pre-push-checks passes.
  • make fmt-check passes.
  • make build passes.
  • Documentation was added/updated where appropriate.
  • Any risk, limitation, or follow-up work is documented.

Summary by CodeRabbit

  • Documentation
    • Updated contributor guidelines to clarify Developer Certificate of Origin (DCO) sign-off requirements for all commits.

Signed-off-by: Amanda H. L. de Andrade Katz <amanda.katz@redhat.com>
@amandahla amandahla force-pushed the amandahla-patch-2 branch from da39f18 to 62c9358 Compare June 11, 2026 19:12
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 84673dcc-a4ef-49ba-bcee-a3845c38c236

📥 Commits

Reviewing files that changed from the base of the PR and between 2c2bf1e and 62c9358.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

Walkthrough

The pull request adds a contributor documentation update to CONTRIBUTING.md, inserting an [!IMPORTANT] callout under the "Commit Messages" section that explicitly requires Developer Certificate of Origin (DCO) sign-off on every commit and directs contributors to use git commit -s to generate the Signed-off-by: Name <email> footer.

Changes

DCO Sign-off Documentation

Layer / File(s) Summary
DCO sign-off requirement callout
CONTRIBUTING.md
Adds an [!IMPORTANT] notice requiring DCO sign-off on every commit with instruction to use git commit -s for the Signed-off-by line.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

approved, lgtm

Suggested reviewers

  • jerichokeyne
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete with most required sections left unfilled (Problem, Detailed Description, Testing, Validation), though commit format and documentation update sections are checked. Complete the PR description by filling out the Detailed Description section explaining the DCO requirement, the Type of Change checkbox (docs), and Behavior After This Change section describing the new requirement for contributors.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a DCO sign-off requirement note to CONTRIBUTING.md documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Pr Checklist Claims Vs Evidence (Generic) ✅ Passed GitHub-visible PR body contains no markdown checklist items matching - [ ] or - [x] (Developer Verification Checklist is rendered as plain bullets).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amandahla-patch-2

Comment @coderabbitai help to get the list of available commands and usage tips.

@amandahla

Copy link
Copy Markdown
Member Author

/override ci/prow/e2e-presubmits-rosa-hcp-private-critical-high-presubmit
/override ci/prow/e2e-presubmits-rosa-sts-private-critical-high-presubmit

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

@amandahla: Overrode contexts on behalf of amandahla: ci/prow/e2e-presubmits-rosa-hcp-private-critical-high-presubmit, ci/prow/e2e-presubmits-rosa-sts-private-critical-high-presubmit

Details

In response to this:

/override ci/prow/e2e-presubmits-rosa-hcp-private-critical-high-presubmit
/override ci/prow/e2e-presubmits-rosa-sts-private-critical-high-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amandahla amandahla added the documentation Improvements or additions to documentation label Jun 12, 2026
@olucasfreitas

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 4fc2482 into main Jun 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes documentation Improvements or additions to documentation lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants