Open
Conversation
MichaHoffmann
force-pushed
the
mhoffmann/cleanup-grpc-opts
branch
from
0ed6264 to
167d4a5
Compare
MichaHoffmann
force-pushed
the
mhoffmann/cleanup-grpc-opts
branch
from
167d4a5 to
5117fc8
Compare
fpetkovski
previously approved these changes
Apr 9, 2026
The endpoint group service config is genuienly useful for all grpc connections. The difference is in the resolver - for groups it will resolve on its own and loadbalnace between the backends for non-groups we use the passthrough resolver which then will loadbalnace between one backend which should be same behavior as today - in turn we get retries on UNAVAILABLE which is still useful. This also unifies the dial option construction which makes it easier to reason about. I also took the liberty to clean up some related stuff. Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
MichaHoffmann
force-pushed
the
mhoffmann/cleanup-grpc-opts
branch
from
5117fc8 to
87e847a
Compare
Contributor
Author
|
Test is a flake and passes locally: The previous capnp test just takes forever to run. |
| "sidecar": { | ||
| { | ||
| Name: "e2e-test-info-sidecar-alone1:9091", | ||
| Name: "passthrough:///e2e-test-info-sidecar-alone1:9091", |
Member
There was a problem hiding this comment.
What is passthrough for here?
Contributor
Author
There was a problem hiding this comment.
It's a Grpc resolver that sends the address to Grpc without resolving - because we already resolved it ourselves
Contributor
Author
There was a problem hiding this comment.
saswatamcode
approved these changes
Apr 14, 2026
Member
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
Thanks! This looks good, hopefully not a breaking change?
Contributor
Author
i hope not! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint group service config is genuienly useful for all grpc connections. The difference is in the resolver - for groups it will resolve on its own and loadbalnace between the backends for non-groups we use the passthrough resolver which then will loadbalnace between one backend which should be same behavior as today - in turn we get retries on UNAVAILABLE which is still useful.
This also unifies the dial option construction which makes it easier to reason about.
I also took the liberty to clean up some related stuff.
Changes
Verification