fix: Fix automatic sort of Composite items in fixed containers#9
fix: Fix automatic sort of Composite items in fixed containers#9EricRibeiro wants to merge 1 commit intomasterfrom
Composite items in fixed containers#9Conversation
|
Hi @the-funnel You have 3 comments made by bots installed on this repo regarding this pull request. Check them below: There is 1 critical comment
There is 1 deploy comment
There is 1 info comment
|
|
Thanks for working on this @EricRibeiro! I'll take a look at it this weekend (hopefully). |
|
I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix! |
| type SetItems = (items: Item[]) => void; | ||
|
|
||
| function setItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) { | ||
| function mutateItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) { |
There was a problem hiding this comment.
What is the reasoning behind the mutate name?
Closes #8
How to test?
Does this PR introduce breaking changes?
No