Conversation
|
Seems to work fine when I quickly tested it (moving an empty directory into the trash), thanks for the fix! |
Member
Author
Awesome! I just gotta do a bit more work on this, as I realized that this will break the appimage in some cases, and it's broken by hard-coding '/bin/mv' as well. |
andy5995
changed the title
Member
Author
|
@durable-vest I've made a change. Could you test this one more time? If it works for you, I'll merge to master and do a release soon. |
andy5995
force-pushed
the
iss-509
branch
4 times, most recently
from
3364054 to
c4eeb23
Compare
Using execvp("mv", ...) searches PATH at runtime instead of compiling
in a build-time path, which also fixes the NixOS case without needing
Meson to discover mv.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rename variables for clarity: BTRFS_IMAGE_MOUNTPOINT -> BTRFS_MOUNTPOINT, IMAGE_PATH -> BTRFS_IMAGE, SUBVOLUME_USED -> BTRFS_SUBVOLUME, WASTE_USED -> BTRFS_WASTE_DIR, TEST_DIR -> BTRFS_TEST_DIR, RMW_TEST_CMD_STRING -> BTRFS_RMW_CMD - Derive BTRFS_SUBVOLUME from BTRFS_MOUNTPOINT instead of hardcoding - Inline single-use IS_BTRFS_MOUNTED variable - Add trashinfo assertions after each move, restore, and purge - Add nested directory test (a/b/c/deep_file) covering safe_mv_via_exec Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@durable-vest I believe this will fix it. Can you test this PR or will it be easier to test after it's merged to master?