tests/tso: stabilize TestLegacyTSOConsistencySuite startup path#10342
tests/tso: stabilize TestLegacyTSOConsistencySuite startup path#10342okJiang wants to merge 1 commit intotikv:masterfrom
Conversation
Signed-off-by: okjiang <819421878@qq.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10342 +/- ##
=======================================
Coverage 78.88% 78.89%
=======================================
Files 527 527
Lines 70920 70920
=======================================
+ Hits 55944 55950 +6
+ Misses 10978 10960 -18
- Partials 3998 4010 +12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Is it ready for review? |
This PR does not address the root cause. I will close it. This PR does not use the most powerful model (it was modified after being updated), I will run it again using the most powerful model. |
What problem does this PR solve?
Issue Number: ref #10332
TestLegacyTSOConsistencySuiteis flaky in CI due to timeout while setting up the suite.Root-cause evidence chain:
tests/integrations/tso/consistency_test.go:82(RunInitialServers)tests/cluster.go:663(RunServerswaiting)tests/cluster.go:652(RunServer.func1blocked send)TestFallbackTSOConsistencyexplicitly tearing down and re-creating the full PD cluster inside one test, which re-enters the known fragile startup path under CI load.What is changed and how does it work?
Historical analog:
test: fix flaky test TestForwardTestSuite in next-gen)RunInitialServersstartup/retry path under CI contention; fix strategy is to avoid unnecessary entry into that path for test stabilization.Fix strategy (minimal):
TestFallbackTSOConsistency, remove in-testTearDownSuite()+SetupSuite()cluster restart.fallBackSync,fallBackUpdate) on the already-initialized suite and always disable viadefer.Risk:
Check List
Tests
Verification commands + results
make gotest GOTEST_ARGS='-tags without_dashboard ./tso -run TestLegacyTSOConsistencySuite -count=1 -v'(intests/integrations): PASSTestLegacyTSOConsistencySuite/TestFallbackTSOConsistency: PASSok github.com/tikv/pd/tests/integrations/tsomake gotest GOTEST_ARGS='-tags without_dashboard ./tso -run TestMicroserviceTSOConsistencySuite/TestFallbackTSOConsistency -count=1 -v'(intests/integrations): PASSTestMicroserviceTSOConsistencySuite/TestFallbackTSOConsistency: PASSok github.com/tikv/pd/tests/integrations/tsoRelease note