Skip to content

dep: upgrade go-deadlock to work with synctest#10545

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
lance6716:upgrade-go-deadlock
Apr 2, 2026
Merged

dep: upgrade go-deadlock to work with synctest#10545
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
lance6716:upgrade-go-deadlock

Conversation

@lance6716
Copy link
Copy Markdown
Contributor

@lance6716 lance6716 commented Apr 1, 2026

What problem does this PR solve?

Issue Number: Close #10536

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated dependency versions used by builds and tests to maintain compatibility and stability.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copilot AI review requested due to automatic review settings April 1, 2026 12:54
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9b4c231b-9357-48ee-b03f-db7a55013b53

📥 Commits

Reviewing files that changed from the base of the PR and between 21c3e0c and f30e8af.

⛔ Files ignored due to path filters (2)
  • tests/integrations/go.sum is excluded by !**/*.sum
  • tools/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • tests/integrations/go.mod
  • tools/go.mod
✅ Files skipped from review due to trivial changes (2)
  • tools/go.mod
  • tests/integrations/go.mod

📝 Walkthrough

Walkthrough

Bumped github.com/sasha-s/go-deadlock from v0.3.6 to v0.3.9 across module files to address compatibility with Go's synctest during test execution.

Changes

Cohort / File(s) Summary
Dependency Version Update
go.mod, tests/integrations/go.mod, tools/go.mod
Updated github.com/sasha-s/go-deadlock from v0.3.6v0.3.9 in three go.mod files; no other require/replace entries or exported API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped through modules, gentle and spry,
Bumped a deadlock watcher to make tests fly,
From .6 to .9 the syncs now align,
No more test-time tangles — a tidy design! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'dep: upgrade go-deadlock to work with synctest' directly and clearly describes the main change: upgrading a dependency to fix compatibility with synctest.
Description check ✅ Passed The PR description follows the required template with Issue Number linking to #10536, though the commit message block and some checklist items are incomplete.
Linked Issues check ✅ Passed The PR successfully addresses Issue #10536 by upgrading go-deadlock from v0.3.6 to v0.3.9, which exceeds the minimum v0.3.7 requirement for synctest compatibility [#10536].
Out of Scope Changes check ✅ Passed All changes are in-scope: only three go.mod files were updated with the same dependency version upgrade directly addressing the linked issue [#10536].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lance6716
Copy link
Copy Markdown
Contributor Author

/cc @bufferflies @okJiang

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades github.com/sasha-s/go-deadlock to a newer release intended to be compatible with Go’s synctest, addressing failures like “select on synctest channel from outside bubble” (Close #10536).

Changes:

  • Bump github.com/sasha-s/go-deadlock from v0.3.6 to v0.3.9 in the root module.
  • Update go.sum checksums accordingly.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates the root module’s go-deadlock dependency to v0.3.9.
go.sum Updates sums to match go-deadlock v0.3.9.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.94%. Comparing base (3eb99ae) to head (f30e8af).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10545      +/-   ##
==========================================
+ Coverage   78.88%   78.94%   +0.06%     
==========================================
  Files         530      532       +2     
  Lines       71548    71802     +254     
==========================================
+ Hits        56439    56684     +245     
+ Misses      11092    11089       -3     
- Partials     4017     4029      +12     
Flag Coverage Δ
unittests 78.94% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 2, 2026
@lance6716
Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-02 02:12:45.98278365 +0000 UTC m=+403971.188143707: ☑️ agreed by okJiang.
  • 2026-04-02 07:09:52.029811452 +0000 UTC m=+421797.235171509: ☑️ agreed by rleungx.

@lance6716
Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 319d880 into tikv:master Apr 2, 2026
32 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

@lance6716: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-2 f30e8af link unknown /test pull-unit-test-next-gen-2
pull-unit-test-next-gen-3 f30e8af link unknown /test pull-unit-test-next-gen-3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade github.com/sasha-s/go-deadlock to be compatible with synctest

4 participants