dep: upgrade go-deadlock to work with synctest#10545
dep: upgrade go-deadlock to work with synctest#10545ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughBumped Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/cc @bufferflies @okJiang |
There was a problem hiding this comment.
Pull request overview
Upgrades github.com/sasha-s/go-deadlock to a newer release intended to be compatible with Go’s synctest, addressing failures like “select on synctest channel from outside bubble” (Close #10536).
Changes:
- Bump
github.com/sasha-s/go-deadlockfromv0.3.6tov0.3.9in the root module. - Update
go.sumchecksums accordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates the root module’s go-deadlock dependency to v0.3.9. |
| go.sum | Updates sums to match go-deadlock v0.3.9. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10545 +/- ##
==========================================
+ Coverage 78.88% 78.94% +0.06%
==========================================
Files 530 532 +2
Lines 71548 71802 +254
==========================================
+ Hits 56439 56684 +245
+ Misses 11092 11089 -3
- Partials 4017 4029 +12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@lance6716: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Close #10536
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note
Summary by CodeRabbit
Release Notes