schedule: add metrcis for region scatter by Yisaer · Pull Request #3582 · tikv/pd

Yisaer · 2021-04-12T10:15:58Z

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

Add metrics in region scatter

What is changed and how it works?

Release note

No release note

Signed-off-by: yisaer <disxiaofei@163.com>

codecov · 2021-04-13T04:45:29Z

Codecov Report

Merging #3582 (da73cd9) into master (b6e80b2) will decrease coverage by 0.07%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
- Coverage   74.61%   74.53%   -0.08%     
==========================================
  Files         245      245              
  Lines       24100    24128      +28     
==========================================
+ Hits        17983    17985       +2     
- Misses       4506     4525      +19     
- Partials     1611     1618       +7

Flag	Coverage Δ
unittests	`74.53% <81.81%> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/region_scatterer.go	`87.04% <80.00%> (-1.58%)`	⬇️
server/schedule/filter/filters.go	`90.76% <100.00%> (ø)`
server/schedule/metrics.go	`100.00% <100.00%> (ø)`
server/tso/global_allocator.go	`70.80% <0.00%> (-6.57%)`	⬇️
server/tso/tso.go	`69.93% <0.00%> (-2.46%)`	⬇️
server/tso/allocator_manager.go	`73.25% <0.00%> (-2.16%)`	⬇️
tools/pd-ctl/pdctl/command/operator.go	`65.99% <0.00%> (-1.22%)`	⬇️
server/handler.go	`41.97% <0.00%> (-0.50%)`	⬇️
server/server.go	`73.36% <0.00%> (-0.16%)`	⬇️
client/client.go	`71.82% <0.00%> (-0.14%)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e80b2...da73cd9. Read the comment docs.

Signed-off-by: Song Gao <disxiaofei@163.com>

Yisaer · 2021-04-13T05:19:55Z

/cc @rleungx

rleungx · 2021-04-13T05:35:31Z

BTW, can we add the related information of the filter?

Signed-off-by: yisaer <disxiaofei@163.com>

rleungx · 2021-04-13T12:02:42Z

+}
+
+// StoreBusyFilter
+type storeBusyFilter struct {


How about using StoreStateFilter

Signed-off-by: yisaer <disxiaofei@163.com>

ti-chi-bot · 2021-04-15T03:52:58Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

nolouch · 2021-04-15T03:53:02Z

/merge

ti-chi-bot · 2021-04-15T03:53:03Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-04-15T03:53:05Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 147cc10

sonarqubecloud · 2021-04-15T03:53:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

rleungx · 2021-04-15T05:15:49Z

/merge

ti-chi-bot · 2021-04-15T05:15:50Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Yisaer · 2021-04-15T07:23:07Z

/merge

ti-chi-bot · 2021-04-15T07:23:08Z

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-15T07:40:20Z

cherry pick to release-4.0 in PR #3595

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-15T07:41:01Z

cherry pick to release-5.0 in PR #3596

* cherry pick #3582 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * fix conflict Signed-off-by: yisaer <disxiaofei@163.com> Co-authored-by: Song Gao <disxiaofei@163.com>

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2021

ti-chi-bot requested review from lhy1024 and rleungx April 12, 2021 10:16

Yisaer added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. labels Apr 12, 2021

rleungx mentioned this pull request Apr 13, 2021

Show the reason why the store cannot be a candidate when doing scatter regions #3581

Open

add metrcis

42e13ff

Signed-off-by: yisaer <disxiaofei@163.com>

Yisaer force-pushed the add_metrics_for_scatter branch from 8142fcd to 42e13ff Compare April 13, 2021 04:27

add metrics json

f89a647

Signed-off-by: Song Gao <disxiaofei@163.com>

Yisaer marked this pull request as ready for review April 13, 2021 05:19

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021

rleungx reviewed Apr 13, 2021

View reviewed changes

Comment thread server/schedule/region_scatterer.go Outdated

Yisaer added 3 commits April 13, 2021 15:29

address the comment

9b672f9

Signed-off-by: yisaer <disxiaofei@163.com>

address the comment

8137f98

Signed-off-by: yisaer <disxiaofei@163.com>

address the comment

521c3f9

Signed-off-by: yisaer <disxiaofei@163.com>

rleungx reviewed Apr 13, 2021

View reviewed changes

address the comment

147cc10

Signed-off-by: yisaer <disxiaofei@163.com>

Yisaer requested a review from rleungx April 14, 2021 06:41

lhy1024 approved these changes Apr 14, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021

nolouch approved these changes Apr 15, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021

Merge branch 'master' into add_metrics_for_scatter

da73cd9

rleungx reviewed Apr 15, 2021

View reviewed changes

Comment thread metrics/grafana/pd.json

rleungx added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2021

Yisaer merged commit b8c3d14 into tikv:master Apr 15, 2021

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Apr 15, 2021

cherry pick tikv#3582 to release-4.0

cb9d150

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 15, 2021

schedule: add metrcis for region scatter (#3582) #3595

Merged

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Apr 15, 2021

cherry pick tikv#3582 to release-5.0

6d6e3e2

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 15, 2021

schedule: add metrcis for region scatter (#3582) #3596

Merged

Yisaer pushed a commit that referenced this pull request Apr 16, 2021

schedule: add metrcis for region scatter (#3582) (#3596)

3dd3c7b

Conversation

Yisaer commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Release note

Uh oh!

codecov bot commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Yisaer commented Apr 13, 2021

Uh oh!

Uh oh!

rleungx commented Apr 13, 2021

Uh oh!

rleungx Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

Yisaer Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

nolouch commented Apr 15, 2021

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

sonarqubecloud bot commented Apr 15, 2021

Uh oh!

Uh oh!

rleungx commented Apr 15, 2021

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

Yisaer commented Apr 15, 2021

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

ti-srebot commented Apr 15, 2021

Uh oh!

ti-srebot commented Apr 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Yisaer commented Apr 12, 2021 •

edited

Loading

codecov bot commented Apr 13, 2021 •

edited

Loading