*: simplify some code

[rleungx]

What problem does this PR solve?

Remove some duplicated code.

What is changed and how it works?

Just as above says.

Check List

Tests

• Unit test

Release note

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JmPotato
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[rleungx]

/run-unit-tests

[rleungx]

/run-unit-tests

[codecov]

Codecov Report

Merging #3586 (3c69942) into master (9d9c8ee) will increase coverage by 0.00%.
The diff coverage is 92.59%.

@@           Coverage Diff           @@
##           master    #3586   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files         245      245           
  Lines       24139    24108   -31     
=======================================
- Hits        18033    18010   -23     
+ Misses       4499     4489   -10     
- Partials     1607     1609    +2     

Flag	Coverage Δ
unittests	74.70% <92.59%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/core/basic_cluster.go	90.60% <ø> (-0.19%)	⬇️
server/core/store.go	81.30% <ø> (-0.32%)	⬇️
server/schedule/operator_controller.go	86.00% <91.66%> (+2.83%)	⬆️
server/cluster/cluster.go	82.97% <100.00%> (-0.49%)	⬇️
server/schedulers/shuffle_hot_region.go	54.73% <0.00%> (-9.48%)	⬇️
server/election/leadership.go	85.88% <0.00%> (-3.53%)	⬇️
server/schedulers/random_merge.go	60.00% <0.00%> (-3.34%)	⬇️
client/base_client.go	83.24% <0.00%> (-2.17%)	⬇️
server/encryptionkm/key_manager.go	71.78% <0.00%> (-1.66%)	⬇️
server/core/storage.go	67.68% <0.00%> (-1.53%)	⬇️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9c8ee...3c69942. Read the comment docs.

[rleungx]

/merge

[ti-chi-bot]

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: c397c49

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
4.8% Duplication

[JmPotato]

/run-integration-ddl-test