Skip to content

cluster: avoid unexpected statistic modify in range cluster#3599

Merged
lhy1024 merged 5 commits intotikv:masterfrom
lhy1024:fix-range-cluster
Apr 16, 2021
Merged

cluster: avoid unexpected statistic modify in range cluster#3599
lhy1024 merged 5 commits intotikv:masterfrom
lhy1024:fix-range-cluster

Conversation

@lhy1024
Copy link
Copy Markdown
Contributor

@lhy1024 lhy1024 commented Apr 15, 2021

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

After add the scatter range scheduler, will cause the #3598, the disk used space drop to 0. this PR try to fix a part of that.

What is changed and how it works?

#3598 are caused with two problems, this pr fix one, another is #3597

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image
    image

Release note

  • Avoid unexpected statistic modify after adding scatter region scheduler

lhy1024 added 2 commits April 15, 2021 17:39
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot requested review from HunDunDM and rleungx April 15, 2021 13:47
@lhy1024 lhy1024 requested review from Yisaer, disksing and nolouch and removed request for rleungx April 15, 2021 13:47
@lhy1024 lhy1024 added component/schedule Scheduling logic. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. labels Apr 15, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2021

Codecov Report

Merging #3599 (f2b9ce7) into master (b8c3d14) will increase coverage by 0.18%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3599      +/-   ##
==========================================
+ Coverage   74.55%   74.74%   +0.18%     
==========================================
  Files         245      245              
  Lines       24128    24137       +9     
==========================================
+ Hits        17989    18040      +51     
+ Misses       4521     4493      -28     
+ Partials     1618     1604      -14     
Flag Coverage Δ
unittests 74.74% <80.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/store_stats.go 77.77% <66.66%> (-1.17%) ⬇️
server/core/store_option.go 100.00% <100.00%> (ø)
server/schedule/range_cluster.go 87.03% <100.00%> (ø)
server/cluster/cluster.go 83.45% <0.00%> (ø)
server/grpc_service.go 47.62% <0.00%> (+0.22%) ⬆️
server/server.go 72.60% <0.00%> (+0.45%) ⬆️
server/core/storage.go 69.20% <0.00%> (+0.76%) ⬆️
server/tso/allocator_manager.go 78.07% <0.00%> (+0.99%) ⬆️
server/tso/tso.go 72.39% <0.00%> (+2.45%) ⬆️
pkg/etcdutil/etcdutil.go 88.23% <0.00%> (+3.52%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c3d14...f2b9ce7. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
lhy1024 added 2 commits April 16, 2021 12:10
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@lhy1024
Copy link
Copy Markdown
Contributor Author

lhy1024 commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f9ffed9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.4% 7.4% Duplication

@lhy1024 lhy1024 merged commit 9097e68 into tikv:master Apr 16, 2021
@lhy1024 lhy1024 deleted the fix-range-cluster branch April 16, 2021 05:30
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 in PR #3602

lhy1024 added a commit that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/schedule Scheduling logic. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants