Skip to content

metrics/grafana: fix Error showing "Current ID assignment" (#5899)#6016

Merged
ti-chi-bot merged 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-5899-to-release-6.5
Feb 17, 2023
Merged

metrics/grafana: fix Error showing "Current ID assignment" (#5899)#6016
ti-chi-bot merged 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-5899-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Feb 17, 2023

This is an automated cherry-pick of #5899

Signed-off-by: husharp jinhao.hu@pingcap.com

What problem does this PR solve?

Issue Number: Close #5898

What is changed and how does it work?

The old version of idalloc is a globally unique path, and keyspace needs to use id allocator to allocate keyspaceID, so in this pr the id allocator is changed to a general purpose, but not sync metrics.
https://github.com/tikv/pd/pull/5284

image

Release note

None

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 17, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Feb 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 17, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 17, 2023
@HuSharp @ti-chi-bot
fix metrics
e07128c 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp @ti-chi-bot
fix metrics
2a28dcc 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-5899-to-release-6.5 branch from 3cde1f9 to 2a28dcc Compare February 17, 2023 08:31
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 17, 2023
@HuSharp
Copy link
Copy Markdown
Member

HuSharp commented Feb 17, 2023 •
edited
Loading

@nolouch PTAL, thx!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 17, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Feb 17, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Feb 17, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Feb 17, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2a28dcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@ti-chi-bot ti-chi-bot merged commit f07f6ff into tikv:release-6.5 Feb 17, 2023
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @HuSharp @nolouch @JmPotato @VelocityLight
⚡