moving_filter: fix data race with cache result (#6080)

[ti-chi-bot]

This is an automated cherry-pick of #6080

What problem does this PR solve?

Issue Number: Close #6069

What is changed and how does it work?

after #5798 we use cache result in median.Get to reduce memory, but it introduces a write operation in get, so we remove write op in get function to avoid data race. And considering there is more get than add, it still is valid to reduce memory and CPU time.

Check List

Tests

• Unit test
• Integration test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lhy1024]

/merge

[ti-chi-bot]

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 25cef0a

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08 ⚠️

Comparison is base (297cee8) 75.65% compared to head (25cef0a) 75.58%.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-6.5    #6087      +/-   ##
===============================================
- Coverage        75.65%   75.58%   -0.08%     
===============================================
  Files              330      330              
  Lines            32961    32960       -1     
===============================================
- Hits             24937    24913      -24     
- Misses            5875     5895      +20     
- Partials          2149     2152       +3     

Flag	Coverage Δ
unittests	75.58% <100.00%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/movingaverage/median_filter.go	100.00% <100.00%> (ø)
pkg/tempurl/tempurl.go	45.00% <0.00%> (-15.00%)	⬇️
server/tso/local_allocator.go	62.16% <0.00%> (-9.46%)	⬇️
server/region_syncer/client.go	81.34% <0.00%> (-5.23%)	⬇️
server/id/id.go	83.05% <0.00%> (-3.39%)	⬇️
server/region_syncer/server.go	82.96% <0.00%> (-3.30%)	⬇️
server/tso/tso.go	70.22% <0.00%> (-2.81%)	⬇️
server/encryptionkm/key_manager.go	70.11% <0.00%> (-1.60%)	⬇️
server/schedulers/hot_region_v2.go	88.30% <0.00%> (-1.17%)	⬇️
server/statistics/store_collection.go	93.75% <0.00%> (-0.63%)	⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.