online recovery: fix online recovery timeout mechanism (#6108)

[ti-chi-bot]

This is an automated cherry-pick of #6108

What problem does this PR solve?

Issue Number: Close #6107

What is changed and how does it work?

fix online recovery timeout mechanism

Check List

Tests

• Unit test

Release note

Fix the issue that online recovery timeout may not work as expected

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lhy1024
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Patch coverage: 87.77% and no project coverage change.

Comparison is base (7910e2c) 75.65% compared to head (f7b7c69) 75.65%.

❗ Current head f7b7c69 differs from pull request most recent head 34a8df0. Consider uploading reports for the commit 34a8df0 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           release-6.5    #6112   +/-   ##
============================================
  Coverage        75.65%   75.65%           
============================================
  Files              330      330           
  Lines            32975    32968    -7     
============================================
- Hits             24946    24941    -5     
+ Misses            5881     5875    -6     
- Partials          2148     2152    +4     

Flag	Coverage Δ
unittests	75.65% <87.77%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/unsafe_recovery_controller.go	82.62% <87.77%> (+3.91%)	⬆️

... and 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: f7b7c69

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.