Skip to content

region_scatter: fix a bug that PD may panic when scatter region if region is unhealthy (#6128)#6129

Merged
ti-chi-bot merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-6128-to-release-6.5
Mar 9, 2023
Merged

region_scatter: fix a bug that PD may panic when scatter region if region is unhealthy (#6128)#6129
ti-chi-bot merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-6128-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Mar 9, 2023

This is an automated cherry-pick of #6128

What problem does this PR solve?

Issue Number: Close #6099

What is changed and how does it work?

region_scatter: fix a bug that PD may panic when scatter region if region is unhealthy

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix a bug that PD may panic when scatter region if region is unhealthy

HunDunDM added 3 commits March 9, 2023 09:53
@HunDunDM @ti-chi-bot
add unittest
9fe21b4 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM @ti-chi-bot
region_scatter: fix a bug that PD may panic when scatter region if re…
39bbb24 
…gion is unhealthy

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM @ti-chi-bot
tiny fix
42a3a1e 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 9, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 9, 2023
@ti-chi-bot ti-chi-bot requested review from Yisaer and nolouch March 9, 2023 09:53
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 9, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 9, 2023
@HunDunDM
Copy link
Copy Markdown
Member

HunDunDM commented Mar 9, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 9, 2023

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 9, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 42a3a1e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2023
@ti-chi-bot ti-chi-bot merged commit bd80719 into tikv:release-6.5 Mar 9, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Mar 13, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@bufferflies bufferflies bufferflies approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@HunDunDM HunDunDM

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @HunDunDM @nolouch @bufferflies @VelocityLight
⚡