Skip to content

*: add defer to logs the panic reason and stack (#6123)#6154

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-6123-to-release-6.5
May 15, 2023
Merged

*: add defer to logs the panic reason and stack (#6123)#6154
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-6123-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #6123

What problem does this PR solve?

Issue Number: Ref #6099

What is changed and how does it work?

add defer logs the panic reason and stack

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-6123-to-release-6.5 branch from 6276e36 to afe7da6 Compare April 20, 2023 08:40
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (10b691a) 75.67% compared to head (eacfa79) 75.64%.

❗ Current head eacfa79 differs from pull request most recent head bcace52. Consider uploading reports for the commit bcace52 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6154      +/-   ##
===============================================
- Coverage        75.67%   75.64%   -0.04%     
===============================================
  Files              330      330              
  Lines            33009    32984      -25     
===============================================
- Hits             24980    24950      -30     
- Misses            5882     5883       +1     
- Partials          2147     2151       +4     
Flag Coverage Δ
unittests 75.64% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cache/ttl.go 97.95% <100.00%> (+0.02%) ⬆️
pkg/systimemon/systimemon.go 100.00% <100.00%> (ø)
server/election/lease.go 84.50% <100.00%> (-3.90%) ⬇️
server/region_syncer/client.go 85.18% <100.00%> (-2.88%) ⬇️
server/tso/allocator_manager.go 63.56% <100.00%> (-0.64%) ⬇️
server/tso/global_allocator.go 61.45% <100.00%> (+0.20%) ⬆️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2023
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label May 15, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented May 15, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 15, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 15, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: eacfa79

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2023
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 15, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 679c2cc into tikv:release-6.5 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants