Skip to content

minResolvedTS: Provide an API to fetch the store resolved_ts (#6413)#6522

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-6413-to-release-6.5
May 29, 2023
Merged

minResolvedTS: Provide an API to fetch the store resolved_ts (#6413)#6522
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-6413-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #6413

What problem does this PR solve?

Issue Number: Close #6386

What is changed and how does it work?

Provide an API to fetch the store resolved_ts

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 25, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx May 25, 2023 10:04
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-6413-to-release-6.5 branch from 86ba412 to 51f4463 Compare May 25, 2023 10:05
@JmPotato JmPotato requested review from JmPotato and lhy1024 and removed request for HunDunDM May 25, 2023 11:31
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-6413-to-release-6.5 branch from 51f4463 to 992f464 Compare May 25, 2023 11:36
@HuSharp
Copy link
Copy Markdown
Member

HuSharp commented May 25, 2023

@JmPotato @CabinfeverB @lhy1024 PTAL, thx!

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 5.26% and project coverage change: +0.04 🎉

Comparison is base (801601f) 75.56% compared to head (3f3d986) 75.61%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6522      +/-   ##
===============================================
+ Coverage        75.56%   75.61%   +0.04%     
===============================================
  Files              330      330              
  Lines            33072    33091      +19     
===============================================
+ Hits             24991    25021      +30     
- Misses            5913     5914       +1     
+ Partials          2168     2156      -12     
Flag Coverage Δ
unittests 75.61% <5.26%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/min_resolved_ts.go 45.83% <0.00%> (-54.17%) ⬇️
server/cluster/cluster.go 81.33% <0.00%> (-0.35%) ⬇️
server/api/router.go 97.97% <100.00%> (+<0.01%) ⬆️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HuSharp
Copy link
Copy Markdown
Member

HuSharp commented May 29, 2023

@lhy1024 Can you leave a merge label? thx!

@lhy1024
Copy link
Copy Markdown
Contributor

lhy1024 commented May 29, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 29, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 29, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3f3d986

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8e9d0c4 into tikv:release-6.5 May 29, 2023
@HuSharp HuSharp deleted the cherry-pick-6413-to-release-6.5 branch May 29, 2023 04:24
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants