pkg: use minimum interface for schedulers#6553
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6553 +/- ##
==========================================
+ Coverage 74.66% 74.69% +0.03%
==========================================
Files 417 417
Lines 42694 42693 -1
==========================================
+ Hits 31876 31891 +15
+ Misses 8007 7995 -12
+ Partials 2811 2807 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pkg/schedule/filter/healthy.go
Outdated
There was a problem hiding this comment.
sche.ScheduleCluster reads like a stutter
|
/merge |
1 similar comment
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 84beac2a4535a9c21176f7a7fab3ff3ddc20e0cc |
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 9592b12 |
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
This PR relies on #6551, please review it after #6551 is merged.
It introduces a minimum interface for schedulers. Once all functions within this interface are implemented, we can run the schedulers.
Check List
Tests
Release note