core: batch get region size by rleungx · Pull Request #7252 · tikv/pd

rleungx · 2023-10-25T09:50:00Z

What problem does this PR solve?

Issue Number: Close #7248.

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot · 2023-10-25T09:50:03Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-10-25T10:02:48Z

Codecov Report

Merging #7252 (56aac2d) into master (47ba96f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7252      +/-   ##
==========================================
- Coverage   74.41%   74.41%   -0.01%     
==========================================
  Files         446      446              
  Lines       48423    48433      +10     
==========================================
+ Hits        36034    36040       +6     
+ Misses       9203     9201       -2     
- Partials     3186     3192       +6

Flag	Coverage Δ
unittests	`74.41% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024

fix 7248?

lhy1024 · 2023-10-26T05:42:15Z

pkg/core/region.go

-func (r *RegionsInfo) GetRegionSizeByRange(startKey, endKey []byte) int64 {
-	r.t.RLock()
-	defer r.t.RUnlock()
+func (r *RegionsInfo) GetRegionSizeByRange(startKey, endKey []byte, limit int) int64 {


Do we need to add bench for it?

nolouch · 2023-10-31T09:30:11Z

can we do some simulate test?

server/cluster/cluster.go

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2023-11-07T10:16:48Z

I added a benchmark and ran it in my local MBP, it shows some improvement.

master


go test -benchmem -run=^$ -bench ^BenchmarkRandomSetRegionWithGetRegionSizeByRange$ github.com/tikv/pd/pkg/core --tags=intest

goos: darwin
goarch: arm64
pkg: github.com/tikv/pd/pkg/core
BenchmarkRandomSetRegionWithGetRegionSizeByRange-12    	   88456	     12543 ns/op	       0 B/op	       0 allocs/op


Running tool: /opt/homebrew/bin/go test -benchmem -run=^$ -bench ^BenchmarkRandomSetRegionWithGetRegionSizeByRangeParallel$ github.com/tikv/pd/pkg/core --tags=intest

goos: darwin
goarch: arm64
pkg: github.com/tikv/pd/pkg/core
BenchmarkRandomSetRegionWithGetRegionSizeByRangeParallel-12    	   22857	     58492 ns/op	     755 B/op	      15 allocs/op
PASS
ok  	github.com/tikv/pd/pkg/core	14.837s

this branch:

Running tool: /opt/homebrew/bin/go test -benchmem -run=^$ -bench ^BenchmarkRandomSetRegionWithGetRegionSizeByRange$ github.com/tikv/pd/pkg/core --tags=intest

goos: darwin
goarch: arm64
pkg: github.com/tikv/pd/pkg/core
BenchmarkRandomSetRegionWithGetRegionSizeByRange-12    	  601136	      1928 ns/op	    4878 B/op	      35 allocs/op
PASS



Running tool: /opt/homebrew/bin/go test -benchmem -run=^$ -bench ^BenchmarkRandomSetRegionWithGetRegionSizeByRangeParallel$ github.com/tikv/pd/pkg/core --tags=intest

goos: darwin
goarch: arm64
pkg: github.com/tikv/pd/pkg/core
BenchmarkRandomSetRegionWithGetRegionSizeByRangeParallel-12    	  241456	      5818 ns/op	   12736 B/op	     103 allocs/op
PASS
ok  	github.com/tikv/pd/pkg/core	16.234s

nolouch · 2023-11-07T10:23:25Z

PTAL @rleungx @lhy1024

Signed-off-by: nolouch <nolouch@gmail.com>

lhy1024

LGTM, but ci failed

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2023-11-08T03:18:27Z

/merge

ti-chi-bot · 2023-11-08T03:18:29Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-08T03:18:31Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 56aac2d

ti-chi-bot · 2023-11-08T03:19:19Z

In response to a cherrypick label: new pull request created to branch release-6.5: #7329.

close tikv#7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2023-11-08T03:19:56Z

In response to a cherrypick label: new pull request created to branch release-7.1: #7331.

close tikv#7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2023-11-08T03:20:33Z

In response to a cherrypick label: new pull request created to branch release-7.5: #7332.

close #7248 Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>

nolouch · 2024-01-10T13:02:19Z

/run-cherry-picker

ti-chi-bot · 2024-01-10T13:02:48Z

In response to a cherrypick label: new pull request created to branch release-6.1: #7693.

close tikv#7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

close #7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

batch get region size

0052176

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Oct 25, 2023

ti-chi-bot bot requested review from HunDunDM and disksing October 25, 2023 09:50

ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2023

lhy1024 reviewed Oct 26, 2023

View reviewed changes

nolouch reviewed Nov 1, 2023

View reviewed changes

server/cluster/cluster.go Outdated Show resolved Hide resolved

add benchmark

8073cb9

Signed-off-by: nolouch <nolouch@gmail.com>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2023

nolouch approved these changes Nov 7, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2023

nolouch force-pushed the batch-get-size branch from d25c907 to 7982009 Compare November 7, 2023 10:50

fix

2a8ae9c

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the batch-get-size branch from 7982009 to 2a8ae9c Compare November 7, 2023 10:52

lhy1024 approved these changes Nov 7, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2023

fix test

1dbb94f

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the batch-get-size branch from c6f20a1 to 1dbb94f Compare November 7, 2023 19:08

ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2023

Merge branch 'master' into batch-get-size

56aac2d

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2023

ti-chi-bot bot merged commit d651c6b into tikv:master Nov 8, 2023

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 8, 2023

This is an automated cherry-pick of tikv#7252

f88fd75

close tikv#7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 8, 2023

core: batch get region size (#7252) #7329

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 8, 2023

This is an automated cherry-pick of tikv#7252

51e326f

close tikv#7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 8, 2023

core: batch get region size (#7252) #7331

Merged

ti-chi-bot mentioned this pull request Nov 8, 2023

core: batch get region size (#7252) #7332

Merged

rleungx deleted the batch-get-size branch November 8, 2023 04:27

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 10, 2024

This is an automated cherry-pick of tikv#7252

b5e9460

close tikv#7248 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jan 10, 2024

core: batch get region size (#7252) #7693

Merged

Conversation

rleungx commented Oct 25, 2023 • edited by lhy1024 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lhy1024 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lhy1024 Oct 26, 2023

Choose a reason for hiding this comment

Uh oh!

nolouch commented Oct 31, 2023

Uh oh!

Uh oh!

nolouch commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nolouch commented Nov 7, 2023

Uh oh!

lhy1024 left a comment

Choose a reason for hiding this comment

Uh oh!

nolouch commented Nov 8, 2023

Uh oh!

ti-chi-bot bot commented Nov 8, 2023

Uh oh!

ti-chi-bot bot commented Nov 8, 2023

Uh oh!

ti-chi-bot commented Nov 8, 2023

Uh oh!

ti-chi-bot commented Nov 8, 2023

Uh oh!

ti-chi-bot commented Nov 8, 2023

Uh oh!

nolouch commented Jan 10, 2024

Uh oh!

ti-chi-bot commented Jan 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rleungx commented Oct 25, 2023 •

edited by lhy1024

Loading

ti-chi-bot bot commented Oct 25, 2023 •

edited

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading

lhy1024 left a comment •

edited

Loading

nolouch commented Nov 7, 2023 •

edited

Loading