Skip to content

go.mod: upgrade gin version from v1.8.1 to v1.9.1#7451

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
niubell:feature-gin-security
Nov 27, 2023
Merged

go.mod: upgrade gin version from v1.8.1 to v1.9.1#7451
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
niubell:feature-gin-security

Conversation

@niubell
Copy link
Copy Markdown
Contributor

@niubell niubell commented Nov 27, 2023

What problem does this PR solve?

Issue Number: Close #7438

What is changed and how does it work?

Upgrade Gin version to v1.9.1 to solve some security issues

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

Upgrade Gin version to v1.9.1 to solve some security issues.

Signed-off-by: niubell <bigpyer@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 27, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 27, 2023
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 27, 2023

Hi @niubell. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx November 27, 2023 08:23
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 27, 2023
@rleungx
Copy link
Copy Markdown
Member

rleungx commented Nov 27, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 27, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2023

Codecov Report

Merging #7451 (cf75fc7) into master (a09717b) will decrease coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head cf75fc7 differs from pull request most recent head 0f5fba5. Consider uploading reports for the commit 0f5fba5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7451      +/-   ##
==========================================
- Coverage   74.25%   74.15%   -0.10%     
==========================================
  Files         451      451              
  Lines       49692    49593      -99     
==========================================
- Hits        36898    36775     -123     
- Misses       9488     9517      +29     
+ Partials     3306     3301       -5     
Flag Coverage Δ
unittests 74.15% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

go.mod Outdated
gotest.tools/gotestsum v1.7.0
)

require (
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about merging line 66-73 with line 75?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2023
@JmPotato
Copy link
Copy Markdown
Member

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 27, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 27, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0f5fba5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 82ace6f into tikv:master Nov 27, 2023
@niubell niubell deleted the feature-gin-security branch November 28, 2023 02:05
@rleungx rleungx added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Nov 28, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7459.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 28, 2023
close tikv#7438

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
close #7438

Upgrade Gin version to v1.9.1 to solve some security issues

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: niubell <bigpyer@126.com>
Co-authored-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 11, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7514.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7515.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2023
close tikv#7438

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
close #7438

Upgrade Gin version to v1.9.1 to solve some security issues

Signed-off-by: niubell <bigpyer@gmail.com>

Co-authored-by: niubell <bigpyer@gmail.com>
ti-chi-bot bot added a commit that referenced this pull request Dec 11, 2023
close #7438

Upgrade Gin version to v1.9.1 to solve some security issues

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: niubell <bigpyer@126.com>
Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: Hu# <jinhao.hu@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Gin Web Framework version to solve some security issues

5 participants